perf: lazy-load extension framework modules - #1208
Open
lczyk wants to merge 1 commit into
Open
Conversation
the extensions package eagerly imported all six framework modules at import time, and gunicorn pulled in the full `packaging` parser chain. none of it is needed for an extension-free `rockcraft pack`. register zero-arg loader callables instead of the classes themselves; the registry resolves a loader on first `get_extension_class` and caches the class back in its place. a module `__getattr__` keeps the `extensions.<ClassName>` attribute access working for callers that rely on it. framework modules are now imported only when an extension is actually applied or listed. warm `import rockcraft.cli` drops the `rockcraft.extensions` subtree from ~18ms to ~1-2ms and `rockcraft.commands` from ~30ms to ~12ms; on the cold managed-instance squashfs the per-module cost scales up further.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just an idea.
the extensions package eagerly imported all six framework modules at import time. for most
rockcraft ...calls its not needed. i've changed the extensions to be lazy loaded (ahead of https://peps.python.org/pep-0810/ landing in 3.15)make lint && make test.