fix(pebble): avoid pydantic warning for exec checks - #1196
Conversation
37fbe6a to
ec259e3
Compare
|
Hi! Just gently following up on this one. I rebased the branch onto current
The focused test run passes with Happy to adjust anything else if useful. |
narrow check to Mapping before key lookup and build the tag list by membership instead of set intersection so the return type stays str; cast the marshalled checks dict in the new test.
lczyk
left a comment
There was a problem hiding this comment.
@gcomneno thanks for the PR! :) looks good. i've let the CI run and noticed the linting errors, so here is a PR to your PR where i've tried to placate our type-checking overlords. ff to use or ignore. 🤷♀️
not gonna 'request changes' since the PR is sound, but dont wanna quite 'approve' since the linting wants some care.
@tigarmo bump. i'm poking at this because just run into the same thing
|
Thanks @lczyk, I merged your patch and reran the focused checks locally. Validation:
The branch is now updated at |
Summary
Issue