go-framework: fail early when no Go sources are present - #1114
Open
gcomneno wants to merge 1 commit into
Open
Conversation
gcomneno
force-pushed
the
fix/go-framework-missing-go-sources
branch
from
March 17, 2026 10:20
23901c7 to
6297d0c
Compare
gcomneno
force-pushed
the
fix/go-framework-missing-go-sources
branch
from
May 24, 2026 16:07
6297d0c to
08a57ef
Compare
Contributor
Author
|
Hi! Just gently following up on this one. I rebased the branch onto current
The focused test run passes with Happy to adjust anything else if useful. |
Contributor
Author
|
Friendly ping on this PR. It has been idle for a while, and it should still be ready from my side. Please let me know if you would like me to rebase, refresh the checks, or adjust anything else. Thanks! |
gcomneno
force-pushed
the
fix/go-framework-missing-go-sources
branch
from
July 31, 2026 10:15
08a57ef to
dd7a846
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes the go-framework extension validate that the project contains at least one Go source file.
Motivation: projects with a go.mod but no .go files can otherwise reach later stages and fail with lower-level errors.
Unit tests were updated to add a minimal main.go in valid test cases.