Skip to content

docs: make package-slices.svg readable in dark mode - #1108

Open
gcomneno wants to merge 2 commits into
canonical:mainfrom
gcomneno:contrib/issue-840-svg-darkmode-only
Open

docs: make package-slices.svg readable in dark mode#1108
gcomneno wants to merge 2 commits into
canonical:mainfrom
gcomneno:contrib/issue-840-svg-darkmode-only

Conversation

@gcomneno

Copy link
Copy Markdown
Contributor

Fixes #840

The package slicing SVG used black strokes/fills on a transparent background, making arrows/text hard to see in dark mode. Use currentColor for black stroke/fill so the diagram follows the documentation theme.

@medubelko medubelko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This renders the same in the preview:

image

https://canonical-ubuntu-documentation-library--1108.com.readthedocs.build/rockcraft/1108/explanation/chisel/

It might be easier to give the lines a neutral grey that works in all modes.

@gcomneno

Copy link
Copy Markdown
Contributor Author

Good catch — I've pushed an update that replaces currentColor with consistent neutral greys for both strokes and labels in package-slices.svg, so it should render clearly in both light and dark themes. The preview should now reflect the change.

@medubelko medubelko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@gcomneno

Copy link
Copy Markdown
Contributor Author

Noticed that one slow test job (jammy, amd64, 3.10) is failing, while the rest of the checks are passing. Since this PR only adjusts an SVG in the docs, this might be unrelated. Could this be rerun to confirm whether it's a flake?

@gcomneno
gcomneno force-pushed the contrib/issue-840-svg-darkmode-only branch from a5726ac to f550a79 Compare March 17, 2026 10:29
@asanvaq

asanvaq commented Mar 23, 2026

Copy link
Copy Markdown
Collaborator

Hi @gcomneno! These are expected/persistent CI failures. This also applies to all the other PRs.

@gcomneno

gcomneno commented Mar 23, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for clarifying — understood. I’ll treat those failures as persistent/unrelated and won’t take any further action on this PR (or any other PRs) unless something specific comes up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Graphs in Chisel Documentation not very readable in dark mode

4 participants