Skip to content

fix: correct common.mk help target listing - #1105

Merged
tigarmo merged 3 commits into
canonical:mainfrom
gcomneno:fix/941-commonmk-help-output
May 26, 2026
Merged

fix: correct common.mk help target listing#1105
tigarmo merged 3 commits into
canonical:mainfrom
gcomneno:fix/941-commonmk-help-output

Conversation

@gcomneno

Copy link
Copy Markdown
Contributor

Fix common.mk help output by preserving target names when parsing Makefile entries.

Fixes #941.

@asanvaq

asanvaq commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

Hi! This PR also contains changes from #1103 and #1106. As the purpose of this PR is to fix common.mk help output, could you please update it so it only addresses this?

@gcomneno
gcomneno force-pushed the fix/941-commonmk-help-output branch from 877bd1c to 6f78087 Compare March 4, 2026 16:41
@gcomneno

gcomneno commented Mar 4, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the review! I’ve rewritten the branch history so this PR now contains only the common.mk help output fix (single commit, single file). The unrelated changes have been moved back to their respective PRs.

@jahn-junior jahn-junior left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Much better. Thanks

medubelko added a commit to medubelko/starbase that referenced this pull request Mar 11, 2026
lengau pushed a commit to canonical/starbase that referenced this pull request Mar 11, 2026

@asanvaq asanvaq left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gcomneno

Copy link
Copy Markdown
Contributor Author

Thanks. I checked the failing QA job for this PR.

The failing test appears to be unrelated to the common.mk help output change in this PR. The failure comes from the Python plugin integration path and is caused by a package fetch error (python3.12 ... 404 Not Found) during staging.

Given that, this looks like CI noise / external environment drift rather than a regression introduced by this change. Would it make sense to treat this class of unrelated failures separately so they do not block small, unrelated fixes like this one?

@gcomneno

Copy link
Copy Markdown
Contributor Author

Hi! Just gently following up on this approved PR.

As far as I can tell, the remaining blockers are stale/unrelated CI failures rather than feedback on the common.mk help output change itself.

Could someone please rerun the failed jobs when convenient, or let me know if anything else is needed from my side?

@tigarmo
tigarmo merged commit 6ae769e into canonical:main May 26, 2026
16 of 17 checks passed
lengau pushed a commit that referenced this pull request Jun 18, 2026
Co-authored-by: Anna Sancho Vaquer <anna.sanchovaquer@canonical.com>
Co-authored-by: Michael DuBelko <michael.dubelko@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: broken common.mk default target

6 participants