Skip to content

docs: update contributing guide from Launchpad to GitHub#505

Open
GreyViperTooth wants to merge 1 commit into
canonical:mainfrom
GreyViperTooth:fix/update-contributing-guidelines-to-github
Open

docs: update contributing guide from Launchpad to GitHub#505
GreyViperTooth wants to merge 1 commit into
canonical:mainfrom
GreyViperTooth:fix/update-contributing-guidelines-to-github

Conversation

@GreyViperTooth

Copy link
Copy Markdown

The project moved to GitHub, but docs/contributing.md still referenced Launchpad for cloning, pushing branches, and submitting merge requests. Updated all instructions and links to use GitHub workflows and URLs.

Fixes: #377

The project moved to GitHub, but docs/contributing.md still referenced
Launchpad for cloning, pushing branches, and submitting merge requests.
Update all instructions and links to use GitHub workflows and URLs.

Fixes: canonical#377

@blackboxsw blackboxsw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the doc change @GreyViperTooth. Minor nits and I thnk we can land this.

Comment thread docs/contributing.md

```shell
git clone https://git.launchpad.net/pycloudlib
git clone https://github.com/GH_USER/pycloudlib

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For push rights I think this may need to me a different remote
git clone git@github.com:GH_USER/pycloudlib.git

Comment thread docs/contributing.md
changes are getting made, not what as that is obvious.

Fixes LP: #1234567
Fixes: #1234

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's standardize on less special characters for the footer.
The following will suffice which better indicates the bug origin (github versus launchpad or some other downstream.

Suggested change
Fixes: #1234
Fixes GH-1234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Contributing guidelines seem outdated

2 participants