tests: add test for VG with no LV#168
Merged
Merged
Conversation
Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
There was a problem hiding this comment.
Pull request overview
This PR adds regression coverage for LVM probing when volume groups and physical volumes exist but no logical volumes are detected.
Changes:
- Adds a test ensuring
lvm.probe()still returnsphysical_volumesandvolume_groups. - Verifies
logical_volumesis omitted when no LVs are present.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Chris-Peterson444
approved these changes
May 27, 2026
Chris-Peterson444
left a comment
Chris-Peterson444
left a comment
Collaborator
There was a problem hiding this comment.
Nice, makes sense to me. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot suggested adding this test in #167