feat: scheduled service start - #917
Open
hpidcock wants to merge 9 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces scheduled starting of services using the existing timer format
defined by snapd. To achieve this, a new field,
schedule, is added to theservice layer schema. Additionally, the
pebble servicescommand has an extracolumn/field,
scheduled, which necessitated adding a complementary field tothe
/v1/servicesGET endpoint.The internal mechanism for starting services on a schedule is implemented in
internals/overlord/servstate/schedule.go, which utilises changes/tasks forstate keeping. The timer wakeup is driven through deferring the task into the
future, when that time passes the schedule is reassessed either deferring again
or adding a service start task to the change to be handled immediately.
An example of a one-shot service that runs periodically:
To see when it is scheduled next we can use the
pebble servicescommand:If we need to see more information on past runs, we can use the
pebble changescommand:
It is then possible to dive deeper into the change to look at the tasks with
the
pebble taskscommand:References