Skip to content

feat: publish charm detect all charm artefacts - #963

Merged
yanksyoon merged 8 commits into
mainfrom
feat/charm-publish-detect-multi-job
Mar 10, 2026
Merged

feat: publish charm detect all charm artefacts#963
yanksyoon merged 8 commits into
mainfrom
feat/charm-publish-detect-multi-job

Conversation

@yanksyoon

@yanksyoon yanksyoon commented Mar 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Applicable spec:

Working run proof

https://github.com/canonical/jenkins-agent-operator/actions/runs/22840905575/job/66248356984?pr=139 (PR: canonical/jenkins-agent-operator#139)

Overview

  • Publish charm workflow now collects all plans from a given workflow, merges them and detects all charms that should be published from a given workflow run.

Rationale

Workflow Changes

  • Publish workflow now merges all the plans generated in a single workflow run.

Checklist

@yanksyoon
yanksyoon requested a review from a team as a code owner March 9, 2026 06:44
@yanksyoon
yanksyoon requested review from javierdelapuente and yhaliaw and removed request for a team March 9, 2026 06:44
yanksyoon
yanksyoon commented Mar 9, 2026
View reviewed changes
Comment thread .github/workflows/integration_test.yaml Outdated
@yanksyoon yanksyoon changed the title feat: charm publish detect multi job feat: publish charm detect all charm artefacts Mar 9, 2026
cbartz
cbartz approved these changes Mar 9, 2026
View reviewed changes

@cbartz cbartz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but one question regarding multi-charm support

Comment thread src/publish.ts
@github-actions

github-actions Bot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Test results for commit 5498038

Test coverage for 5498038

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       8      8      0      0     0%   8-25
----------------------------------------------------------
TOTAL              8      8      0      0     0%

Static code analysis report

Run started:2026-03-10 03:39:40.092246+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 56
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@github-actions

github-actions Bot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Test results for commit 5498038

Test coverage for 5498038

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       8      8      0      0     0%   8-25
----------------------------------------------------------
TOTAL              8      8      0      0     0%

Static code analysis report

Run started:2026-03-10 03:39:40.963752+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 56
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@github-actions

github-actions Bot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Test results for commit 5498038

Test coverage for 5498038

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       8      8      0      0     0%   8-25
----------------------------------------------------------
TOTAL              8      8      0      0     0%

Static code analysis report

Run started:2026-03-10 03:39:38.000691+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 56
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@github-actions

github-actions Bot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Test results for commit 5498038

Test coverage for 5498038

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       8      8      0      0     0%   8-25
----------------------------------------------------------
TOTAL              8      8      0      0     0%

Static code analysis report

Run started:2026-03-10 03:39:40.092246+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 56
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@github-actions

github-actions Bot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Test results for commit 5498038

Test coverage for 5498038

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       8      8      0      0     0%   8-25
----------------------------------------------------------
TOTAL              8      8      0      0     0%

Static code analysis report

Run started:2026-03-10 03:39:40.963752+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 56
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@github-actions

github-actions Bot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Test results for commit 5498038

Test coverage for 5498038

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       8      8      0      0     0%   8-25
----------------------------------------------------------
TOTAL              8      8      0      0     0%

Static code analysis report

Run started:2026-03-10 03:39:38.000691+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 56
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@github-actions

github-actions Bot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Unused entries in .trivyignore

Image: ghcr.io/canonical/test-foo:73ebae26eaf71e0462669ed86b00b03f1351934e-_1.0_amd64

The following CVEs are in .trivyignore but not ignored by Trivy anymore:

1 similar comment
@github-actions

github-actions Bot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Unused entries in .trivyignore

Image: ghcr.io/canonical/test-foo:73ebae26eaf71e0462669ed86b00b03f1351934e-_1.0_amd64

The following CVEs are in .trivyignore but not ignored by Trivy anymore:

@github-actions

github-actions Bot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Unused entries in .trivyignore

Image: ghcr.io/canonical/test:a8ba9319ad0fe10278b87cf705838818e280ccdd-_1.0_amd64

The following CVEs are in .trivyignore but not ignored by Trivy anymore:

@yanksyoon
yanksyoon merged commit 0c11bc1 into main Mar 10, 2026
103 checks passed
@yanksyoon
yanksyoon deleted the feat/charm-publish-detect-multi-job branch March 10, 2026 03:53
@yanksyoon yanksyoon mentioned this pull request Mar 10, 2026
Closed
@weiiwang01 weiiwang01 mentioned this pull request Mar 17, 2026
Closed
3 tasks
jansdhillon pushed a commit to jansdhillon/operator-workflows that referenced this pull request Jun 1, 2026
@yanksyoon @jansdhillon
feat: publish charm detect all charm artefacts (canonical#963)
449cd84 
* feat: merged plan & publish multiple charms

* ci: test workflow

* docs: changelog

* ci: distribute build

* ci: revert back to main

* ci: rebuild dist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbartz cbartz cbartz approved these changes
@arturo-seijas arturo-seijas arturo-seijas approved these changes
@javierdelapuente javierdelapuente Awaiting requested review from javierdelapuente javierdelapuente was automatically assigned from canonical/platform-engineering
@yhaliaw yhaliaw Awaiting requested review from yhaliaw yhaliaw was automatically assigned from canonical/platform-engineering

Assignees

No one assigned

Labels

complex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yanksyoon @cbartz @arturo-seijas