ci(Build-Rock): add flag to run rockcraft test conditionally - #475
Closed
alesancor1 wants to merge 72 commits into
Closed
ci(Build-Rock): add flag to run rockcraft test conditionally#475alesancor1 wants to merge 72 commits into
alesancor1 wants to merge 72 commits into
Conversation
cjdcordeiro
requested changes
Jun 27, 2025
| type: string | ||
| rockcraft-test: | ||
| description: "Whether to run rockcraft test when packing the rock" | ||
| type: boolean |
Collaborator
There was a problem hiding this comment.
this means it's mandatory, but it's optional in the action. wanna default to false?
Member
Author
There was a problem hiding this comment.
GH Actions docs suggest that required is false by default, as it is only necessary to specify it when something is actually required (i.e set to true). So it should work anyway, as the action itself will consider test: false if no value is passed down to it.
In any case, I added the default value just to be safe 👍
Check: 8d319ed
* ci: decouple vulnerability-scan workflow from oci-factory The input required only for OCI-Factory are now optional. A check has been added for it.
Co-authored-by: lucabello <lucabello@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: sed-i <sed-i@users.noreply.github.com>
Co-authored-by: observability-noctua-bot <observability-noctua-bot@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: zhijie-yang <zhijie.yang@canonical.com>
alesancor1
force-pushed
the
ROCKS-2151/rockcraft-test-integration
branch
from
July 1, 2025 10:42
c61e814 to
a14427a
Compare
|
@alesancor1 please make sure all PR contributors have signed the CLA. |
|
One or more files in this PR are not valid! 😬 See logs. |
Member
Author
|
Messed PR - will create it again: #492 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ping the @canonical/rocks team.
Description
A new flag to the
rockcraft packaction will be added to conditionally runrockcraft test. This PR adapts the current reusableBuild-Rockworkflow to cope with the new flag.Blocked by: canonical/craft-actions#40