Fix: support WireGuard link-local remotes with ifindex specifier#596
Open
mvitale1989 wants to merge 2 commits into
Open
Fix: support WireGuard link-local remotes with ifindex specifier#596mvitale1989 wants to merge 2 commits into
mvitale1989 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Netplan currently rejects Wireguard link-local remotes, if they specify an interfaces index.
For instance, setting
endpoint: "[fe80::5054:ff:fe75:5b1f%enp1s0]:51820"on a peer fails with the following error:This is a bug as these are valid IPv6 addresses, and wireguard itself accepts them without any issue:
This PR introduces support for an arbitrary ifindex string, within a Wireguard remote endpoint specification.
I wasn't yet able to file this as a bug on Launchpad as I'm not receiving the e-mail verification to create an account, but I'm opening the PR already as I had the fix ready.
Checklist
make checksuccessfully.make check-coverage). (the new lines are covered)