internal/rest/resources/cluster: Return 404 when member is not found - #752
Merged
roosterfish merged 1 commit intoJun 11, 2026
Merged
Conversation
roosterfish
requested changes
Jun 11, 2026
roosterfish
left a comment
roosterfish
left a comment
Contributor
There was a problem hiding this comment.
Thanks, good catch.
I see you have also opened up two more PRs for v3 and v2. Please make sure those commits are picked using git cherry-pick -x to keep the history from where the changes are coming from.
claudiubelu
force-pushed
the
v4-return-404-member-not-found
branch
from
June 11, 2026 10:30
b19a744 to
031b427
Compare
…rors clusterMemberDelete is returning a SmartError when the given member is absent from the truststore. This makes it difficult for callers to distinguish "not found" from a real internal error. Switch to NotFound error, so callers can use IsNotFoundError to treat an already-absent member as a success. Additionally switched other client-related errors into BadRequest. Signed-off-by: Claudiu Belu <cbelu@cloudbasesolutions.com>
claudiubelu
force-pushed
the
v4-return-404-member-not-found
branch
from
June 11, 2026 11:43
031b427 to
b1b192d
Compare
Contributor
Author
I've updated those branches as well, applying the same fixes to them via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clusterMemberDeleteis returning aSmartErrorwhen the given member is absent from the truststore. This makes it difficult for callers to distinguish "not found" from a real internal error.Switch to
NotFounderror, so callers can useIsNotFoundErrorto treat an already-absent member as a success.