Test: Run joiners in isolated terminals - #871
Merged
Merged
Conversation
roosterfish
marked this pull request as draft
July 11, 2025 12:14
roosterfish
marked this pull request as ready for review
July 11, 2025 13:11
roosterfish
force-pushed
the
isolated_join_env
branch
from
July 11, 2025 13:28
e43b203 to
2a5edfa
Compare
roosterfish
changed the title
roosterfish
force-pushed
the
isolated_join_env
branch
from
July 11, 2025 13:54
2a5edfa to
a652604
Compare
simondeziel
reviewed
Jul 11, 2025
The test output is very convoluted as it prints together the output of all systems joining the cluster (as well as the initiator). By running it in separate terminals we can ensure the outputs are not mixed. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Usually the joiners exit before the initiator. However during failures (e.g. test inputs) the joiners might still be running after the initiator exited out. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
roosterfish
force-pushed
the
isolated_join_env
branch
from
July 13, 2025 10:38
a652604 to
39bcb5b
Compare
simondeziel
approved these changes
Jul 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test output is very convoluted as it prints together the output of all systems joining the cluster (as well as the initiator).
By running it in separate terminals we can ensure the outputs are not mixed.
To make this work for each joiner a new tmux session gets spawned to which we write the interactive test input.