Test: Display correct total e2e evacuation tries number - #867
Merged
Conversation
Contributor
Author
|
The e2e failure is unrelated. |
The EVACUATION_COUNTS always starts at 1 so subtracting 1 causes the display of a wrong value for the total number of tries. When setting EVACUATION_COUNTS to 10, you can see the job printing '(10/9)' for the last try: https://github.com/canonical/microcloud/actions/runs/16188650147/job/45708968808#step:3:6339 Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
roosterfish
force-pushed
the
fix_evac_count
branch
from
July 11, 2025 10:11
edb02f3 to
d253503
Compare
markylaing
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
EVACUATION_COUNTSalways starts at 1 so subtracting 1 causes the display of a wrong value for the total number of tries.When setting
EVACUATION_COUNTSto 10, you can see the job printing(10/9)for the last try: https://github.com/canonical/microcloud/actions/runs/16188650147/job/45708968808#step:3:6339