GitHub: Split tests into smaller suites - #865
Merged
Merged
Conversation
Contributor
Author
|
|
markylaing
requested changes
Jul 11, 2025
markylaing
left a comment
markylaing
left a comment
Contributor
There was a problem hiding this comment.
Just a small nit to keep things similar to the LXD suite.
This allows getting much faster test feedback by separating out longer tests into their own bucket. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
… test There also is the reuse_cluster test which doesn't have the extra *member in the name. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Also merge the test groups to lower the nesting level as we can just call the tests from the first condition's block directly. Also order by name descending. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
markylaing
approved these changes
Jul 14, 2025
Contributor
Author
|
The failing non_ha test is unrelated to this PR. The storage pool creation sometimes is flaky if the MicroCeph cluster just got bootstrapped, added another line here to track it further #653. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows getting faster test feedback.
Currently the
interactivetest suite runs for over 2h which is tedious.The PRs finally splits tests into more granular suites.