Service: Allow distributed storage config without adding new disks - #859
Merged
Conversation
roosterfish
force-pushed
the
reuse_ceph_fix
branch
3 times, most recently
from
July 9, 2025 09:15
d2c0fe2 to
bea2dad
Compare
roosterfish
force-pushed
the
reuse_ceph_fix
branch
from
July 10, 2025 07:22
acd2f5a to
ffe516e
Compare
roosterfish
force-pushed
the
reuse_ceph_fix
branch
8 times, most recently
from
July 14, 2025 12:59
39c3cea to
fefbd15
Compare
roosterfish
marked this pull request as ready for review
July 14, 2025 14:14
We don't anymore print newlines in the terminal as this collides with different terminal windows sizes as we cannot simply determine the best place for the newline. Instead the text breaks naturally in case of smaller window sizes. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
…skipped Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
markylaing
requested changes
Jul 22, 2025
markylaing
left a comment
markylaing
left a comment
Contributor
There was a problem hiding this comment.
A few nitpicks about variable names and comments but the main thing is the loop over each member to collect the configured ceph disks. It seems odd to be looping over each member when there is a comment stating that we only need to get the disks once.
roosterfish
force-pushed
the
reuse_ceph_fix
branch
2 times, most recently
from
July 22, 2025 10:14
f6fc16d to
c5575c3
Compare
markylaing
reviewed
Jul 22, 2025
…isks This allows understanding which disks on which cluster members are already configured for remote storage. The information can then be yielded to the user and allows skipping the selection of additional disks in case the user only wants to configure distributed storage without adding additional disks to MicroCeph. That scenario is important when adding an existing MicroCeph cluster to MicroCloud. Also move the availableDiskCount to narrow its scope to where it is actually used. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
When adding an already existing MicroCeph cluster, a user doesn't have to add additional disks and can solely reuse the disks already configured in the cluster. In case neither the existing cluster nor the systems have any available disks, skip distributed storage. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
…here is at least one disk In case only the existing MicroCeph cluster is providing disks, don't ask to select additional disks if there are none. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
…ommendations warning Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
…rinted Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
This allows to configure distributed Ceph storage but without asking for additional disks (in case there are none). In this case the existing Ceph cluster including it's already configured disks are used. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
…ng new disks This tests to configure distributed storage using an existing Ceph cluster without adding additional disks. That is a valid scenario where Ceph is already fully setup and just needs to be integrated into MicroCloud. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
roosterfish
force-pushed
the
reuse_ceph_fix
branch
from
July 22, 2025 12:07
c5575c3 to
f0a7e53
Compare
Contributor
|
Looks like there is a failed test though, I'm not sure if that one was already flaky? |
Contributor
Author
Yeah the e2e is flaky, but after we get canonical/lxd#16071 in we can then finally merge #798 which should resolve the issues we see with this test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preceded by:
Fixes #812.
The PR ensures that an existing (configured) MicroCeph cluster can be reused by MicroCloud without the need of having to add additional disks during the process.
In a scenario with multiple nodes running MicroCeph, a user might decide to leverage the MicroCeph cluster which is already configured with OSDs for MicroCloud. MicroCloud allows this re-use and asks during the interactive questionnaire if the user wants to reuse this existing cluster.
However until now MicroCloud required to add additional disks (OSDs) to be able to include this existing cluster.
This limitation is now removed and the re-use of disks is made more transparent to the user by printing the already configured disks if the user decides to re-use the existing MicroCeph cluster.