Service: Remove already used disks from selection - #853
Merged
Conversation
roosterfish
marked this pull request as draft
July 8, 2025 07:26
Allow passing a certificate which allows reaching out to the remote MicroCeph (through MicroCloud) using the temporary trust store to fetch the list of already used disks. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Pass nil as the certificate as the cluster is already formed at this stage and we don't anymore need to rely on the temporary trust store but can instead communicate with the local MicroCeph directly. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Pass nil as the certificate as the cluster is already formed at this stage and we don't anymore need to rely on the temporary trust store but can instead communicate with the local MicroCeph directly. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
This allows a more wider use of the disk path formatting across the code base. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
roosterfish
force-pushed
the
fix_disk_reuse
branch
2 times, most recently
from
July 8, 2025 08:30
cdc5e29 to
801a8a4
Compare
Ensure that when collecting a system's information we don't return any disks which are already used by MicroCloud for either local or remote storage. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
roosterfish
force-pushed
the
fix_disk_reuse
branch
from
July 8, 2025 09:01
801a8a4 to
6997df9
Compare
…e contribution When growing a cluster (microcloud add), it might be that the already existing members don't anymore have any left over disks. In this case they aren't marked to contribute disks to the local storage when adding new cluster members. Therefore we can skip those and only ever exit in case a member which should contribute local storage doesn't have any disks. That is the case when creating a new cluster or when adding a cluster member which cannot fulfill the requirement of the already existing cluster. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
roosterfish
marked this pull request as ready for review
July 8, 2025 12:19
markylaing
approved these changes
Jul 10, 2025
markylaing
left a comment
markylaing
left a comment
Contributor
There was a problem hiding this comment.
Again - all makes sense and well structured, thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #847
Ensure that when collecting system information during bootstrap/join of MicroCloud clusters, disks which are already used for either MicroCeph OSDs (remote storage) or zfs (local storage) are filtered out.
This also positively influences some of the findings of #812.