CLI: Use consistent colors - #834
Merged
Merged
Conversation
roosterfish
marked this pull request as ready for review
June 27, 2025 08:58
markylaing
reviewed
Jun 27, 2025
markylaing
previously approved these changes
Jun 27, 2025
markylaing
left a comment
markylaing
left a comment
Contributor
There was a problem hiding this comment.
LGTM I think this will make the setup text a lot less busy 🚀
roosterfish
force-pushed
the
consistent_colors
branch
from
June 27, 2025 11:58
f733f23 to
524885c
Compare
The MicroCloud TUI uses yellow for warnings and red for errors. Using yellow also for input highlights is confusing. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
…essages Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
…Warning Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
This allows influencing the error caused on wrong inputs. To stay consistent with the other tui errors we cannot use LXD's asker as we cannot modify the yielded error. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
roosterfish
force-pushed
the
consistent_colors
branch
from
June 30, 2025 07:19
524885c to
da82ff2
Compare
markylaing
approved these changes
Jun 30, 2025
minaelee
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #797
Overview
The reason for this PR is to be more cautious with colors in the new tui.
We are using three central colors green, yellow and red to indicate:
Especially user provided input should not be repeated using the warning color to not confuse the user and to really make warnings and errors stand out.
The new tui styling allows highlighting input using bold text which already is enough as it stands out from regular text.
In addition the way we output errors and warnings is now consistently performed through dedicated functions.
Furthermore we use our own asker (not anymore the one from LXD) so we can influence the error message using our own styling.
Single node MicroCloud deployment
Multi node MicroCloud deployment
Standard errors