doc: update snaps and releases documentation - #829
Conversation
34b4840 to
fc818dc
Compare
roosterfish
left a comment
There was a problem hiding this comment.
Thanks for this, left a few comments to highlight the differences between LXD and MicroCloud releases and some more smaller details that might be helpful too.
| cd integration/microceph/docs/ && $(MAKE) html BUILDDIR=$(current_dir)/_build/microceph | ||
| cd integration/microovn/docs/ && $(MAKE) html BUILDDIR=$(current_dir)/_build/microovn | ||
| $(MAKE) -f Makefile.sp sp-html BUILDDIR=$(current_dir)/_build/microcloud | ||
| $(MAKE) -f Makefile.sp sp-html BUILDDIR=$(current_dir)/_build/microcloud ADDPREREQS='gitpython pyyaml' |
There was a problem hiding this comment.
I am trying to follow what this change is all about as it doesn't match the commit message.
Can you please move this change (and probably the other ADDPREREQS) into a separate commit?
There was a problem hiding this comment.
Ah now I see, you require the pyyaml to load the substitutions file. Can you maybe add a comment somewhere?
For what is gitpython used?
There was a problem hiding this comment.
Moved into a separate commit without gitpython but can't confirm that it will work without until after #839 is merged (per tests currently failing due to MicroCeph changes).
There was a problem hiding this comment.
PR can be rebased now, the other PR just went in.
edc7bc6 to
a115f71
Compare
|
Test won't pass until #839 is merged. Will rebase after. |
0442198 to
83c3966
Compare
|
Updated the compatibility matrix to include feature releases: Supported and compatible releases
|
…snaps Signed-off-by: Minae Lee <minae.lee@canonical.com>
Signed-off-by: Minae Lee <minae.lee@canonical.com>
Signed-off-by: Minae Lee <minae.lee@canonical.com>
Signed-off-by: Minae Lee <minae.lee@canonical.com>
Signed-off-by: Minae Lee <minae.lee@canonical.com>
Signed-off-by: Minae Lee <minae.lee@canonical.com>
This PR: