Skip to content

Trivy: Account for non existing latest/ track - #1441

Merged
roosterfish merged 1 commit into
canonical:mainfrom
roosterfish:fix_snap_download
Jul 3, 2026
Merged

Trivy: Account for non existing latest/ track#1441
roosterfish merged 1 commit into
canonical:mainfrom
roosterfish:fix_snap_download

Conversation

@roosterfish

@roosterfish roosterfish commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

In MicroCloud we don't use latest/ track but instead only track numbers.
Only latest/edge get populated.

I have reverted some of the changes in #1440 as its easier to carry the branch name as MicroCloud doesn't publish latest/stable.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Trivy GitHub Actions workflow to scan MicroCloud snap tracks using explicit branch names instead of relying on a latest/* snap track that MicroCloud does not publish.

Changes:

  • Replaces the snap scan matrix from string versions (latest, 2) to track/branch pairs.
  • Updates checkout ref selection and SARIF naming to use the configured branch.
  • Updates snap download channel selection to use the configured track number.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/security.yml Outdated
Comment thread .github/workflows/security.yml Outdated
Comment thread .github/workflows/security.yml Outdated
Comment thread .github/workflows/security.yml Outdated
Comment thread .github/workflows/security.yml Outdated
Comment thread .github/workflows/security.yml Outdated
In MicroCloud we don't use latest/ track but instead only track numbers.
Only latest/edge get populated.

Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@roosterfish
roosterfish marked this pull request as ready for review July 3, 2026 08:29
@roosterfish
roosterfish requested a review from a team July 3, 2026 08:42

@simondeziel simondeziel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in LXD we should start using 6 everywhere latest is used. This should simplify aligning both sides.

@roosterfish

Copy link
Copy Markdown
Contributor Author

I think in LXD we should start using 6 everywhere latest is used. This should simplify aligning both sides.

If this is passing here, I can create a PR on LXD if you like.

@roosterfish
roosterfish merged commit 45130a0 into canonical:main Jul 3, 2026
53 of 54 checks passed
@roosterfish
roosterfish deleted the fix_snap_download branch July 3, 2026 11:40
@simondeziel

Copy link
Copy Markdown
Member

I think in LXD we should start using 6 everywhere latest is used. This should simplify aligning both sides.

If this is passing here, I can create a PR on LXD if you like.

That would be much appreciated, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants