Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/bot_pr_approval.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,8 @@ on:

jobs:
bot_pr_approval:
if: github.event.pull_request.user.login != 'github-actions[bot]'
uses: canonical/operator-workflows/.github/workflows/bot_pr_approval.yaml@main
permissions:
pull-requests: write
secrets: inherit
6 changes: 6 additions & 0 deletions docs-check.log
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
E100 [config pipeline failed] Runtime error

no sources provided

Execution stopped with code 1.
make: *** [Makefile.docs:51: vale-sync] Error 2
2 changes: 1 addition & 1 deletion docs/reference/actions.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@

See [Actions](https://charmhub.io/jenkins-agent/actions).

> Read more about actions in the Juju docs: [Action](https://juju.is/docs/juju/action)
> Read more about actions in the Juju docs: [Action](https://documentation.ubuntu.com/juju/3.6/reference/action/)
8 changes: 4 additions & 4 deletions docs/reference/charm-architecture.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ See [Relation endpoints](../reference/integrations.md).
Juju events allow progression of the charm in its lifecycle and encapsulates part of the execution
context of a charm. Below is the list of observed events for `jenkins-agent charm` with how the charm
reacts to the event. For more information about the charm’s lifecycle in general, refer to the
charms life [documentation](https://canonical-juju.readthedocs-hosted.com/en/3.6/user/reference/hook/).
charm's life [documentation](https://documentation.ubuntu.com/juju/3.6/reference/hook/).

### `install`

Expand All @@ -46,7 +46,7 @@ This event triggers the installation of the Jenkins agent service. It also insta
### `start`

This event marks the charm’s state as started. See the documentation on the
[start event](https://canonical-juju.readthedocs-hosted.com/en/3.6/user/reference/hook/#start).
[start event](https://documentation.ubuntu.com/juju/3.6/reference/hook/#start).

### `config-changed`

Expand All @@ -66,9 +66,9 @@ The `upgrade-charm` event is fired on the upgrade charm command `juju refresh je

The `src/charm.py` is the default entry point for a charm and has the JenkinsAgentCharm Python class which inherits from CharmBase.

CharmBase is the base class from which all Charms are formed, defined by [Ops](https://juju.is/docs/sdk/ops) (Python framework for developing charms).
CharmBase is the base class from which all Charms are formed, defined by [Ops](https://canonical.com/juju/docs/ops/latest/) (Python framework for developing charms).

> See more in the Juju docs: [Charm](https://canonical-juju.readthedocs-hosted.com/en/3.6/user/reference/charm/).
> See more in the Juju docs: [Charm](https://documentation.ubuntu.com/juju/3.6/reference/charm/).

The `__init__` method guarantees that the charm observes all events relevant to its operation and handles them.

2 changes: 1 addition & 1 deletion docs/reference/configurations.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@

See [Configurations](https://charmhub.io/jenkins-agent/configure).

> Read more about configurations in the Juju docs: [Configuration](https://juju.is/docs/juju/configuration)
> Read more about configurations in the Juju docs: [Configuration](https://documentation.ubuntu.com/juju/3.6/reference/configuration/)
17 changes: 15 additions & 2 deletions lib/charms/operator_libs_linux/v1/systemd.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,20 @@
# limitations under the License.


"""Abstractions for stopping, starting and managing system services via systemd.
"""Legacy Charmhub-hosted systemd library, deprecated in favour of ``charmlibs.systemd``.

WARNING: This library is deprecated and will no longer receive feature updates or bugfixes.
``charmlibs.systemd`` version 1.0 is a bug-for-bug compatible migration of this library.
Add 'charmlibs-systemd~=1.0' to your charm's dependencies, and remove this Charmhub-hosted library.
Then replace `from charms.operator_libs_linux.v0 import systemd` with
`from charmlibs import systemd`.
Read more:
- https://documentation.ubuntu.com/charmlibs
- https://pypi.org/project/charmlibs-systemd

---

Abstractions for stopping, starting and managing system services via systemd.

This library assumes that your charm is running on a platform that uses systemd. E.g.,
Centos 7 or later, Ubuntu Xenial (16.04) or later.
Expand Down Expand Up @@ -64,7 +77,7 @@

# Increment this PATCH version before using `charmcraft publish-lib` or reset
# to 0 if you are raising the major API version
LIBPATCH = 4
LIBPATCH = 5


class SystemdError(Exception):
Expand Down
4 changes: 4 additions & 0 deletions lychee-output.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Error: Cannot parse inputs from arguments

Caused by:
Input 'docs/explanation/workload.md' not found as file and not a valid URL. Use full URL (e.g., https://example.com) or check file path.
2 changes: 1 addition & 1 deletion tests/unit/test_agent.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Copyright 2025 Canonical Ltd.
# See LICENSE file for licensing details.
#
# Learn more about testing at: https://juju.is/docs/sdk/testing
# Learn more about testing at: https://canonical.com/juju/docs/ops/latest/

"""Test for agent relations."""

Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test_charm.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Copyright 2025 Canonical Ltd.
# See LICENSE file for licensing details.
#
# Learn more about testing at: https://juju.is/docs/sdk/testing
# Learn more about testing at: https://canonical.com/juju/docs/ops/latest/

"""Test for charm hooks."""

Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test_service.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Copyright 2025 Canonical Ltd.
# See LICENSE file for licensing details.
#
# Learn more about testing at: https://juju.is/docs/sdk/testing
# Learn more about testing at: https://canonical.com/juju/docs/ops/latest/

"""Test for service interaction."""

Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test_state.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Copyright 2025 Canonical Ltd.
# See LICENSE file for licensing details.
#
# Learn more about testing at: https://juju.is/docs/sdk/testing
# Learn more about testing at: https://canonical.com/juju/docs/ops/latest/

"""Test for charm state."""

Expand Down
Loading