[ISD-3570] Flush runner will kill reactive processes as well - #595
Merged
Conversation
yhaliaw
marked this pull request as ready for review
July 18, 2025 01:57
yhaliaw
requested review from
cbartz,
javierdelapuente and
yanksyoon
as code owners
July 18, 2025 01:57
yanksyoon
reviewed
Jul 18, 2025
yanksyoon
left a comment
Member
There was a problem hiding this comment.
LGTM, some comments regarding the architecture which may require team coordination.
yanksyoon
approved these changes
Jul 18, 2025
Contributor
Test results for commit 12a1b80Test coverage for 12a1b80 Static code analysis report |
javierdelapuente
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicable spec:
Overview
Rationale
Checklist
urgent,trivial,complex).