Skip to content

[ISD-3570] Flush runner will kill reactive processes as well - #595

Merged
yhaliaw merged 14 commits into
mainfrom
fix/reactive-flush
Jul 21, 2025
Merged

[ISD-3570] Flush runner will kill reactive processes as well#595
yhaliaw merged 14 commits into
mainfrom
fix/reactive-flush

Conversation

@yhaliaw

@yhaliaw yhaliaw commented Jul 15, 2025

Copy link
Copy Markdown
Collaborator

Applicable spec:

Overview

  • Flush runner will kill the reactive process.
  • Retried reactive job messages are delayed by 60 secs before processing.
  • Flush are done on upgrade charm.

Rationale

  • Fix the issue where the old reactive process persist after a charm upgrade.
  • Fix rapid retry of reactive job messages on error.

Checklist

@yhaliaw
yhaliaw marked this pull request as ready for review July 18, 2025 01:57

@yanksyoon yanksyoon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some comments regarding the architecture which may require team coordination.

Comment thread .github/workflows/integration_test.yaml Outdated
@yhaliaw yhaliaw changed the title Flush runner will kill reactive processes as well [ISD-3570] Flush runner will kill reactive processes as well Jul 18, 2025
@github-actions

Copy link
Copy Markdown
Contributor

Test results for commit 12a1b80

Test coverage for 12a1b80

Wrote XML report to coverage/coverage.xml

Static code analysis report

Run started:2025-07-21 00:47:24.641770

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 2024
  Total lines skipped (#nosec): 2
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 1

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@yhaliaw
yhaliaw enabled auto-merge (squash) July 21, 2025 07:33
@yhaliaw
yhaliaw merged commit d0947c6 into main Jul 21, 2025
95 of 106 checks passed
@yhaliaw
yhaliaw deleted the fix/reactive-flush branch July 21, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants