Skip to content

chore: split reconcile duration seconds into buckets - #594

Merged
yanksyoon merged 4 commits into
mainfrom
chore/reconcile-duration-buckets
Jul 29, 2025
Merged

chore: split reconcile duration seconds into buckets#594
yanksyoon merged 4 commits into
mainfrom
chore/reconcile-duration-buckets

Conversation

@yanksyoon

Copy link
Copy Markdown
Member

Applicable spec: N/A

Overview

  • Changes reconcile duration prometheus data histogram buckets into minute basis buckets.

Rationale

  • Reconcile duration is not sub second. By default the buckets are split into sub-second groups. We want to group them into minute groups [60, 2 * 60, 5 * 60, 10 * 60, 15 * 60, float("inf")].

Juju Events Changes

Module Changes

Library Changes

Checklist

No user affecting changes.

@cbartz cbartz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a line to the changelog, pls? Otherwise LGTM

@github-actions

Copy link
Copy Markdown
Contributor

Test results for commit 477813c

Test coverage for 477813c

Wrote XML report to coverage/coverage.xml

Static code analysis report

Run started:2025-07-28 16:07:31.605187

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 2024
  Total lines skipped (#nosec): 2
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 1

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@github-actions

Copy link
Copy Markdown
Contributor

TICS Quality Gate

❌ Failed

The following errors have occurred during analysis:

❌ [ERROR 5333] Project database 'github-runner-operator' already is connected to a started TICSQServer process that has not registered a stop time. To avoid data corruption, analysis is aborted. Details of the other TICSQServer process: started at 2025-07-09 14:32:08.000 by user ubuntu.

.github/workflows/tics.yaml / TICS / TICS GitHub Action

@yanksyoon
yanksyoon merged commit fd0dcfd into main Jul 29, 2025
89 of 117 checks passed
@yanksyoon
yanksyoon deleted the chore/reconcile-duration-buckets branch July 29, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants