Skip to content

Fix the default value of the aproxy-exclude-addresses configuration - #593

Merged
weiiwang01 merged 4 commits into
mainfrom
fix-aproxy-exclude-addresses
Jul 15, 2025
Merged

Fix the default value of the aproxy-exclude-addresses configuration#593
weiiwang01 merged 4 commits into
mainfrom
fix-aproxy-exclude-addresses

Conversation

@weiiwang01

Copy link
Copy Markdown
Collaborator

Applicable spec:

Overview

The default configuration value for aproxy-exclude-addresses is currently 10.0.0.0/8, 171.16.0.0/12, 192.168.0.0/16, but it should be 10.0.0.0/8, 172.16.0.0/12, 192.168.0.0/16.

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

@cbartz

cbartz commented Jul 14, 2025

Copy link
Copy Markdown
Collaborator

@weiiwang01 can you pls update the changelog?

@weiiwang01

Copy link
Copy Markdown
Collaborator Author

@weiiwang01 can you pls update the changelog?

Yes, updated, thanks!

@cbartz

cbartz commented Jul 14, 2025

Copy link
Copy Markdown
Collaborator

@weiiwang01 can you pls update the changelog?

Yes, updated, thanks!

@weiiwang01 have you pushed the commit? I don't see a changelog change.

@weiiwang01

Copy link
Copy Markdown
Collaborator Author

@weiiwang01 can you pls update the changelog?

Yes, updated, thanks!

@weiiwang01 have you pushed the commit? I don't see a changelog change.

Sorry, the push failed because an additional commit was added to the remote. I have merged the remote into main and pushed the commit.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for commit 373411d

Test coverage for 373411d

Wrote XML report to coverage/coverage.xml

Static code analysis report

Run started:2025-07-14 19:38:59.669410

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 2055
  Total lines skipped (#nosec): 2
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 1

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@weiiwang01
weiiwang01 merged commit 4b71c7b into main Jul 15, 2025
112 of 122 checks passed
@weiiwang01
weiiwang01 deleted the fix-aproxy-exclude-addresses branch July 15, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants