Fix the default value of the aproxy-exclude-addresses configuration - #593
Merged
Conversation
weiiwang01
requested review from
cbartz,
javierdelapuente,
yanksyoon and
yhaliaw
as code owners
July 14, 2025 15:29
javierdelapuente
approved these changes
Jul 14, 2025
cbartz
approved these changes
Jul 14, 2025
Collaborator
|
@weiiwang01 can you pls update the changelog? |
Collaborator
Author
Yes, updated, thanks! |
Collaborator
@weiiwang01 have you pushed the commit? I don't see a changelog change. |
…to fix-aproxy-exclude-addresses
Collaborator
Author
Sorry, the push failed because an additional commit was added to the remote. I have merged the remote into main and pushed the commit. |
Contributor
Test results for commit 373411dTest coverage for 373411d Static code analysis report |
yanksyoon
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicable spec:
Overview
The default configuration value for
aproxy-exclude-addressesis currently10.0.0.0/8, 171.16.0.0/12, 192.168.0.0/16, but it should be10.0.0.0/8, 172.16.0.0/12, 192.168.0.0/16.Rationale
Juju Events Changes
Module Changes
Library Changes
Checklist
urgent,trivial,complex).