Skip to content

Fix/manager test fix - #592

Closed
yanksyoon wants to merge 2 commits into
mainfrom
fix/manager-test-fix
Closed

Fix/manager test fix#592
yanksyoon wants to merge 2 commits into
mainfrom
fix/manager-test-fix

Conversation

@yanksyoon

Copy link
Copy Markdown
Member

Applicable spec:

Overview

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

@github-actions

github-actions Bot commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

Test results for commit 59203ec

Test coverage for 59203ec

Wrote XML report to coverage/coverage.xml

Static code analysis report

Run started:2025-07-09 06:58:52.995483

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 2050
  Total lines skipped (#nosec): 2
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 1

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@github-actions

github-actions Bot commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

TICS Quality Gate

✔️ Passed

github-runner-operator

All conditions passed

See the results in the TICS Viewer

The following files have been checked for this project
  • github-runner-manager/src/github_runner_manager/github_client.py
  • github-runner-manager/tests/unit/test_github_client.py
  • tests/integration/test_runner_manager_openstack.py

.github/workflows/tics.yaml / TICS / TICS GitHub Action

@yanksyoon

Copy link
Copy Markdown
Member Author

CLOSING: discussed that the flakiness is in the test due to underlying infrastructure - and such interface test is no longer needed as it is covered in other e2e tests.

@yanksyoon yanksyoon closed this Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant