Skip to content

feat: parallel deletion of runners - #588

Merged
yanksyoon merged 56 commits into
mainfrom
feat/parallel-instance-deletion
Jul 24, 2025
Merged

feat: parallel deletion of runners#588
yanksyoon merged 56 commits into
mainfrom
feat/parallel-instance-deletion

Conversation

@yanksyoon

@yanksyoon yanksyoon commented Jul 2, 2025

Copy link
Copy Markdown
Member

Applicable spec: N/A

Overview

  • Uses thread pool executor to concurrently submit delete requests, which includes:
    • Concurrent platform provider (GitHub) delete
    • Concurrent VM delete from OpenStack
    • Concurrent metrics fetching over SSH

Rationale

  • To remove serial delete bottleneck in reconcile loop.

Juju Events Changes

Module Changes

Library Changes

Checklist

No user facing changes.

Comment thread github-runner-manager/src/github_runner_manager/manager/runner_manager.py Outdated
Comment thread github-runner-manager/src/github_runner_manager/manager/cloud_runner_manager.py Outdated

@yanksyoon yanksyoon left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR review help comments

Comment thread github-runner-manager/src/github_runner_manager/metrics/runner.py
Comment thread github-runner-manager/src/github_runner_manager/manager/runner_manager.py Outdated
Comment thread github-runner-manager/tests/unit/fake_runner_managers.py Outdated
Comment thread github-runner-manager/src/github_runner_manager/manager/runner_manager.py Outdated
@yhaliaw
yhaliaw self-requested a review July 21, 2025 06:58
@yanksyoon yanksyoon mentioned this pull request Jul 22, 2025
6 tasks
@github-actions

Copy link
Copy Markdown
Contributor

Test results for commit b06bf0b

Test coverage for b06bf0b

Wrote XML report to coverage/coverage.xml

Static code analysis report

Run started:2025-07-24 02:23:38.822381

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 2024
  Total lines skipped (#nosec): 2
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 1

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@github-actions

Copy link
Copy Markdown
Contributor

TICS Quality Gate

❌ Failed

The following errors have occurred during analysis:

❌ [ERROR 5333] Project database 'github-runner-operator' already is connected to a started TICSQServer process that has not registered a stop time. To avoid data corruption, analysis is aborted. Details of the other TICSQServer process: started at 2025-07-09 14:32:08.000 by user ubuntu.

.github/workflows/tics.yaml / TICS / TICS GitHub Action

@yanksyoon
yanksyoon enabled auto-merge (squash) July 24, 2025 05:47
@yanksyoon
yanksyoon merged commit 5b822a7 into main Jul 24, 2025
72 of 76 checks passed
@yanksyoon
yanksyoon deleted the feat/parallel-instance-deletion branch July 24, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants