feat: jobmanager token authentication - #587
Merged
Merged
Conversation
cbartz
marked this pull request as ready for review
July 2, 2025 10:52
cbartz
requested review from
javierdelapuente,
yanksyoon and
yhaliaw
as code owners
July 2, 2025 10:52
javierdelapuente
approved these changes
Jul 4, 2025
yhaliaw
reviewed
Jul 7, 2025
yhaliaw
reviewed
Jul 7, 2025
yhaliaw
reviewed
Jul 7, 2025
yanksyoon
reviewed
Jul 7, 2025
yanksyoon
left a comment
Member
There was a problem hiding this comment.
Reviewed until srcs, tests pending.
yanksyoon
reviewed
Jul 11, 2025
yanksyoon
left a comment
Member
There was a problem hiding this comment.
A minor comment on inheritance, thanks!
cbartz
commented
Jul 14, 2025
yanksyoon
approved these changes
Jul 14, 2025
yanksyoon
left a comment
Member
There was a problem hiding this comment.
LGTM, non-blocking nits, thank you!
yhaliaw
approved these changes
Jul 15, 2025
…752' into feat/jobmanager-token-auth-ISD-3752
cbartz
enabled auto-merge (squash)
July 15, 2025 05:23
Contributor
Test results for commit 9bef95bTest coverage for 9bef95b Static code analysis report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicable spec:
Overview
Support HTTP Bearer Token authentication with the jobmanager and make it required.
Rationale
Communication with the jobmanager requires authentication.
Juju Events Changes
n/a
Module Changes
Library Changes
n/a
Checklist
urgent,trivial,complex).jobmanager support is still considered hidden feature, so there is no official documentation