[ISD-3791] Fix: Add timeouts for ghapi calls - #586
Merged
Conversation
yhaliaw
marked this pull request as ready for review
July 1, 2025 02:18
yhaliaw
requested review from
cbartz,
javierdelapuente and
yanksyoon
as code owners
July 1, 2025 02:18
cbartz
reviewed
Jul 1, 2025
cbartz
approved these changes
Jul 1, 2025
javierdelapuente
approved these changes
Jul 1, 2025
Contributor
Test results for commit a401192Test coverage for a401192 Static code analysis report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add timeouts for all ghapi calls.
The ghapi uses urllib for making the HTTP requests to GitHub. By default there is no timeout.
This PR sets the timeout and catches the errors of urllib.
Rationale
From an investigation in the stuck process/thread in github-runner-manager, it seems it is stuck at the ghapi calls for HTTP request to GitHub.Since the HTTP request by ghapi with urllib has no timeout, this is the most likely reason for the stuck process/thread.
EDIT: This is likely not the reason for the stuck process/thread. However, setting timeouts is generally a good practice.
Checklist
urgent,trivial,complex).