Skip to content

feat: prometheus metrics - #582

Merged
cbartz merged 78 commits into
mainfrom
feat/prometheus-metrics
Jul 9, 2025
Merged

feat: prometheus metrics#582
cbartz merged 78 commits into
mainfrom
feat/prometheus-metrics

Conversation

@yanksyoon

@yanksyoon yanksyoon commented Jun 23, 2025

Copy link
Copy Markdown
Member

Applicable spec:

Overview

  • Adds prometheus metrics to the GitHub runner manager application
  • Adds prometheus integration via COSAgent relation

** Note that the metrics were requested without refactoring which may lead to inconsistent or faulty metrics, due to the nature of the structure of the code. Any faulty metrics are NOT part of the responsibility of this PR.

Rationale

  • To get observability into the charm/application.

Juju Events Changes

Module Changes

Library Changes

Checklist

@yanksyoon yanksyoon changed the title [WIP] feat: prometheus metrics feat: prometheus metrics Jun 30, 2025

@cbartz cbartz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Comment thread .github/workflows/integration_test.yaml Outdated
Comment thread github-runner-manager/src/github_runner_manager/manager/runner_manager.py Outdated
Comment thread github-runner-manager/src/github_runner_manager/manager/runner_scaler.py Outdated
Comment thread github-runner-manager/src/github_runner_manager/manager/runner_manager.py Outdated
Comment thread github-runner-manager/src/github_runner_manager/http_server.py Outdated
@yanksyoon
yanksyoon requested a review from cbartz June 30, 2025 07:58
@cbartz
cbartz enabled auto-merge (squash) July 1, 2025 05:48
@yanksyoon
yanksyoon force-pushed the feat/prometheus-metrics branch from dd94d0c to f53e31e Compare July 2, 2025 12:53
@github-actions

github-actions Bot commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

Test results for commit 6ae9a0d

Test coverage for 6ae9a0d

Wrote XML report to coverage/coverage.xml

Static code analysis report

Run started:2025-07-09 09:11:30.819510

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 2055
  Total lines skipped (#nosec): 2
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 1

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@github-actions

github-actions Bot commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

TICS Quality Gate

✔️ Passed

github-runner-operator

All conditions passed

See the results in the TICS Viewer

The following files have been checked for this project
  • github-runner-manager/src/github_runner_manager/http_server.py
  • github-runner-manager/src/github_runner_manager/manager/runner_manager.py
  • github-runner-manager/src/github_runner_manager/manager/runner_scaler.py
  • github-runner-manager/src/github_runner_manager/metrics/reconcile.py
  • github-runner-manager/src/github_runner_manager/openstack_cloud/openstack_cloud.py
  • github-runner-manager/tests/unit/openstack_cloud/test_openstack_cloud.py
  • src/charm.py
  • tests/integration/conftest.py
  • tests/integration/test_prometheus_metrics.py

.github/workflows/tics.yaml / TICS / TICS GitHub Action

@cbartz
cbartz merged commit 426b54e into main Jul 9, 2025
75 of 83 checks passed
@cbartz
cbartz deleted the feat/prometheus-metrics branch July 9, 2025 13:09
@cbartz

cbartz commented Jul 10, 2025

Copy link
Copy Markdown
Collaborator

We decided to remove the integration test test_runner_manager , as those tests are covered in other integration test and it prevented merging due to its flakiness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants