Skip to content

Forward arbitrary TCP traffic using aproxy - #580

Merged
cbartz merged 23 commits into
mainfrom
aproxy-tcp
Jul 7, 2025
Merged

Forward arbitrary TCP traffic using aproxy#580
cbartz merged 23 commits into
mainfrom
aproxy-tcp

Conversation

@weiiwang01

Copy link
Copy Markdown
Collaborator

Applicable spec:

Overview

Update the GitHub runner to allow forwarding arbitrary TCP traffic to an HTTP proxy using aproxy.

Adds two configuration options, aproxy-exclude-addresses and aproxy-redirect-ports, to filter which TCP traffic will be redirected to aproxy.

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

@cbartz cbartz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Some comments regarding validation.

Comment thread github-runner-manager/src/github_runner_manager/configuration/base.py Outdated
Comment thread src/charm_state.py Outdated
Comment thread src/charm_state.py Outdated
Comment thread src/charm_state.py Outdated
Comment thread src/charm_state.py
Comment thread src/charm_state.py Outdated
Comment thread src/charm_state.py
Comment thread src/charm_state.py
@weiiwang01

Copy link
Copy Markdown
Collaborator Author

Temporarily remove the following TCP proxy from the aproxy test in the end-to-end test suite, as the upstream proxy in the test environment is returning a 503 response. I ran the test in the PS7 environment and it worked without any problems.

          printf "" | timeout 60 nc github.com 22 | head -n 1 | grep SSH

@cbartz
cbartz enabled auto-merge (squash) July 3, 2025 12:07
@github-actions

github-actions Bot commented Jul 4, 2025

Copy link
Copy Markdown
Contributor

Test results for commit af5a7dc

Test coverage for af5a7dc

Wrote XML report to coverage/coverage.xml

Static code analysis report

Run started:2025-07-04 15:17:09.400785

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 2050
  Total lines skipped (#nosec): 2
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 1

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@cbartz
cbartz disabled auto-merge July 7, 2025 21:21
@cbartz

cbartz commented Jul 7, 2025

Copy link
Copy Markdown
Collaborator

We have issues with the CI setup, all test passed except the test_runner_manager_openstack. I ran it locally successfully
image
Will force merge the PR.

@cbartz
cbartz merged commit 1aa16ad into main Jul 7, 2025
127 of 166 checks passed
@cbartz
cbartz deleted the aproxy-tcp branch July 7, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants