Skip to content

DNR/DNM : Update Makefile - #176

Draft
jsimpso wants to merge 1 commit into
canonical:mainfrom
jsimpso:main
Draft

DNR/DNM : Update Makefile#176
jsimpso wants to merge 1 commit into
canonical:mainfrom
jsimpso:main

Conversation

@jsimpso

@jsimpso jsimpso commented Dec 5, 2025

Copy link
Copy Markdown

DO NOT MERGE/REVIEW

Applicable spec:

Overview

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

@cbartz
cbartz marked this pull request as draft December 5, 2025 06:18
@cbartz

cbartz commented Dec 5, 2025

Copy link
Copy Markdown
Collaborator

Testing something, do not merge the pr

@cbartz cbartz changed the title Update Makefile DNR/DNM : Update Makefile Dec 5, 2025

@yhaliaw yhaliaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor changes needed


🤝 Human review with AI assistance.

Comment thread Makefile
include Makefile.docs

.PHONY: help
.PHONY: halp

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .PHONY declaration was changed from help to halp, but the help: target immediately below is unchanged. This means help is no longer declared phony — if a file named help ever appears in the repo root, make help would be treated as up-to-date and silently skip running _list-targets. The halp phony entry is dead (no rule exists for it).

Given that the PR description explicitly says "DO NOT MERGE/REVIEW", this looks like a stray/WIP commit. Please revert to .PHONY: help (and drop the trailing space) before this is considered for merge.

Suggested change
.PHONY: halp
.PHONY: help

🤖 AI-assisted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants