DNR/DNM : Update Makefile - #176
Draft
jsimpso wants to merge 1 commit into
Draft
Conversation
jsimpso
requested review from
cbartz,
javierdelapuente,
yanksyoon and
yhaliaw
as code owners
December 5, 2025 06:17
cbartz
marked this pull request as draft
December 5, 2025 06:18
Collaborator
|
Testing something, do not merge the pr |
yhaliaw
approved these changes
Aug 3, 2026
yhaliaw
left a comment
Contributor
There was a problem hiding this comment.
Approved with minor changes needed
🤝 Human review with AI assistance.
| include Makefile.docs | ||
|
|
||
| .PHONY: help | ||
| .PHONY: halp |
Contributor
There was a problem hiding this comment.
The .PHONY declaration was changed from help to halp, but the help: target immediately below is unchanged. This means help is no longer declared phony — if a file named help ever appears in the repo root, make help would be treated as up-to-date and silently skip running _list-targets. The halp phony entry is dead (no rule exists for it).
Given that the PR description explicitly says "DO NOT MERGE/REVIEW", this looks like a stray/WIP commit. Please revert to .PHONY: help (and drop the trailing space) before this is considered for merge.
Suggested change
| .PHONY: halp | |
| .PHONY: help |
🤖 AI-assisted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE/REVIEW
Applicable spec:
Overview
Rationale
Juju Events Changes
Module Changes
Library Changes
Checklist
urgent,trivial,senior-review-required,documentation)app/pyproject.toml