Repository navigation
Conversation
Each snapcfg unset restarts dockerd, taking ~5m per restart on emulated s390x. Combine unsets into single commands where they test independent options, roughly halving the restart count and overall task time. Increase kill-timeout to 60m to accommodate the remaining restarts within the test's margins.
daemon_config alone dominates an s390x lane; the other 14 tasks fit one runner in ~42m worst case (26.04), so split only daemon_config out and drop the hand-kept task list. A new task no longer needs a shard assignment. Shards are numbered after filtering, so a filter that leaves one lane reads as 1/1, and only multi-shard lanes carry a shard suffix in the job name.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
attempt at addressing #404
emulated s390x lanes run past their timeout:
daemon_configrestarts dockerd ~10 times at ~4-6m apiece, so it alone takes 42-45m+ on s390x, on top of ~15-20m allocate + prepare and ~15-22m for the remaining tasks.in this PR we split each s390x system into 2 shards: daemon_config on its own, everything else on the other. we've also managed to reduce the number of unsets slightly from 10 to 8.
rough s390x timings are:
https://github.com/canonical/docker-snap/actions/runs/36532233527