Conversation
Iterate through all packages declared in the project file and create a deb file for each file, adding proper control metadata to each one. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Co-authored-by: cmatsuoka <317355+cmatsuoka@users.noreply.github.com>
Co-authored-by: cmatsuoka <317355+cmatsuoka@users.noreply.github.com>
|
We can land this directly on main after landing #54 |
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive unit tests for the Lifecycle service class, addressing review feedback from PR #54. The tests validate partition-to-package name mapping logic and directory retrieval methods.
- Adds
tests/unit/services/test_lifecycle.pywith tests for the helper function_get_prime_dirs_from_project(), theget_prime_dir()method, and theprime_dirsproperty - Tests cover edge cases including partition prefix stripping, non-package partition filtering, empty partition handling, and error handling for non-existent packages
- All tests use proper mocking and follow the repository's established testing patterns
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot rebase this on main. |
I'm unable to rebase this branch. My environment doesn't support |
|
@copilot merge main into this branch and fix the conflicts. |
Co-authored-by: lengau <4305943+lengau@users.noreply.github.com>
|
@copilot fix the linting issue here. Use conventional commits on your commit message. |
Co-authored-by: lengau <4305943+lengau@users.noreply.github.com>
Fixed the import formatting issue in tools/schema.py in commit 975c0e4. The linting now passes. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
make lint && make test?Addresses review feedback from #54 requesting unit test coverage for the
Lifecycleservice class.Changes
tests/unit/services/test_lifecycle.pywith tests covering:_get_prime_dirs_from_project()helper function (partition-to-package name mapping)Lifecycle.get_prime_dir()method (including error handling for non-existent packages)Lifecycle.prime_dirspropertyTest Coverage
Tests also verify:
DebcraftErroris raised for non-existent package lookups✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.