chore(merge): update starbase (2026-07-22) - #177
Conversation
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com> Co-authored-by: Tiago Nobrega <tiago.nobrega@canonical.com>
…5.12 (#527) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Apply better patterns: - Move `docs/how-to-guides` to `docs/how-to`. - Add meta-project TOC. - Fix indentation in some boilerplate. - Add default descriptions to landing pages. - Fix some ruff linting problems in `conf.py`.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…5.13 (#535) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…5.14 (#536) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* build(docs): update Sphinx Stack to 2.0 * docs: fix autobuild loop * chore: lock deps * docs: revise metadata for homepage and main indexes --------- Signed-off-by: JJ Coldiron <jj.coldiron@canonical.com> Co-authored-by: Michael DuBelko <michael.dubelko@canonical.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Fixes starbase#538 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
The instructions were incorrect and out of date.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Alex M. Lowe <alex.lowe@canonical.com>
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
--------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com> Co-authored-by: Tiago Nobrega <tiago.nobrega@canonical.com>
The `docs-clean` target in the docs Makefile has an ambiguous `test` command that fails if we export a temp directory to it. To work around that, override the target completely, so we don't require a temp dir to delete in the first place.
--------- Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
…5.20 (main) (#571)
…5.21 (main) (#575)
Updates the python-scans job in policy.yaml to use the newest configuration options of starflow's security scanner, including an osv-scanner.toml configuration placeholder and adding exclude paths. --------- Signed-off-by: Alex Lowe <alex.lowe@canonical.com>
Signed-off-by: Alex M. Lowe <alex.lowe@canonical.com>
Implement shell formatting tool (shfmt) as requested in #531. --------- Signed-off-by: Alex Lowe <alex.lowe@canonical.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR merges Starbase-managed baseline updates into Debcraft, refreshing shared tooling/CI configuration and migrating the documentation scaffold to the current Sphinx Stack layout.
Changes:
- Updated Python/tooling configuration (uv groups/constraints, pre-commit hooks, shfmt integration).
- Migrated docs scaffolding to Sphinx Stack (
docs/_dev, updated Sphinx config, templates, and requirements). - Refreshed CI/security scanning workflows (permissions, OSV scanner config, Renovate checks).
Reviewed changes
Copilot reviewed 33 out of 37 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Updates project metadata and dependency groups (docs/types/dev) and uv constraints. |
| osv-scanner.toml | Adds OSV scanner config file used by workflow. |
| Makefile | Adds shfmt to formatting pipeline. |
| docs/tutorials/index.rst | Adds meta description and updates tutorials landing copy. |
| docs/requirements.txt | Syncs Sphinx Stack dependency set/pins for docs builds. |
| docs/release-notes/index.rst | Adds meta description and adjusts toctree settings. |
| docs/reference/index.rst | Adds meta description and updates reference landing copy. |
| docs/README.md | Updates docs subproject instructions from starter pack to Sphinx Stack. |
| docs/Makefile | Migrates docs build tooling paths from .sphinx to _dev, adjusts lint targets. |
| docs/index.rst | Updates site navigation/toctree structure for new docs layout. |
| docs/how-to/index.rst | Adds new how-to landing page to replace removed how-to-guides index. |
| docs/how-to-guides/index.rst | Removes legacy how-to-guides index page. |
| docs/explanation/index.rst | Adds meta description and updates explanation landing copy/toctree. |
| docs/explanation/documentation.rst | Updates external link target to Sphinx Stack reference docs. |
| docs/conf.py | Updates Sphinx configuration to Sphinx Stack conventions and extensions. |
| docs/.sphinx/version | Removes old starter pack version marker. |
| docs/.gitignore | Updates ignored paths for _dev and .venv layout. |
| docs/.custom_wordlist.txt | Adds “Starbase” to custom word list. |
| docs/_templates/header.html | Adds custom header template (navigation/GTM hooks). |
| docs/_templates/footer.html | Adds custom footer template (license, contributors, cookie controls). |
| docs/_static/js/bundle.js | Removes previously committed bundled JS artifact. |
| docs/_static/css/cookie-banner.css | Removes old cookie banner CSS artifact. |
| docs/_dev/version | Adds Sphinx Stack _dev version marker. |
| docs/_dev/update_sp.py | Migrates update script from starter pack to Sphinx Stack upstream. |
| docs/_dev/pa11y.json | Adds pa11y configuration for accessibility checks. |
| docs/_dev/get_vale_conf.py | Updates Vale config fetcher paths to _dev. |
| docs/_dev/.pymarkdown.json | Adds pymarkdown configuration for docs linting. |
| docs/_dev/.pre-commit-config.yaml | Adds docs-specific pre-commit hooks (spelling/linkcheck/woke). |
| CONTRIBUTING.md | Removes bounty-related contribution text. |
| common.mk | Updates shared make targets (help output, shfmt targets, docs targets). |
| AGENTS.md | Adds repository agent/development guidance document. |
| .prettierignore | Excludes docs/_dev from prettier. |
| .pre-commit-config.yaml | Updates ruff hook id and adds shfmt pre-commit hook. |
| .github/workflows/qa.yaml | Adds explicit workflow permissions. |
| .github/workflows/policy.yaml | Switches scan workflow inputs to OSV config + excludes docs groups/paths. |
| .github/workflows/check-renovate.yaml | Installs uv in Renovate validation workflow. |
Comments suppressed due to low confidence (1)
docs/tutorials/index.rst:16
- This page contains an empty
toctree. Sphinx emits a warning for empty toctrees, and the docs Makefile builds with--fail-on-warning, so this can breakmake docs. Either add at least one child page here or remove the toctree until content exists.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merge starbase/main into this branch and sync Starbase-managed updates. Overview of Starbase changes pulled in: - Refreshed shared CI, linting, and workflow baselines. - Migrated docs scaffold to the current Sphinx Stack layout under docs/_dev. - Synced shared build tooling and documentation templates. - Added repository-level OSV scanner configuration. Conflict resolution applied: - Kept child-repo QA workflow behavior and uv.lock ownership decisions. - Kept .github/README.md deleted for this repository type. - Preserved Debcraft-owned project metadata (including project license). - Applied child-specific docs identity and accessibility adjustments over the Starbase scaffold. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
470c499 to
7a77fe9
Compare
medubelko
left a comment
There was a problem hiding this comment.
This is missing the changes to .readthedocs.yaml.
| ogp_site_url = "https://canonical-debcraft.readthedocs-hosted.com/" | ||
|
|
||
| # Preview name of the documentation website | ||
| # TODO: To use a different name for the project in previews, update the next line. |
There was a problem hiding this comment.
| # TODO: To use a different name for the project in previews, update the next line. |
| # 'product_tag': '_static/tag.png', | ||
| # "product_tag": "_static/tag.png", | ||
| # Your Discourse instance URL | ||
| # TODO: Change to your Discourse instance URL or leave empty. |
There was a problem hiding this comment.
| # TODO: Change to your Discourse instance URL or leave empty. |
| # TODO: Change to your Discourse instance URL or leave empty. | ||
| "discourse": "", | ||
| # Your Mattermost channel URL | ||
| # TODO: Change to your Mattermost channel URL or leave empty. |
There was a problem hiding this comment.
| # TODO: Change to your Mattermost channel URL or leave empty. |
| author = "Canonical Ltd." | ||
|
|
||
| # Format the product name and version for the TOC and HTML title | ||
| # TODO: When the product begins versioning, uncomment this block. |
There was a problem hiding this comment.
| # TODO: When the product begins versioning, uncomment this block. |
The TODOs are for initial setup.
|
|
||
| # Product favicon; shown in bookmarks, browser tabs, etc. | ||
| # html_favicon = '.sphinx/_static/favicon.png' | ||
| # TODO: To customise the favicon, uncomment and update the next line. |
There was a problem hiding this comment.
| # TODO: To customise the favicon, uncomment and update the next line. |
| # TODO: If your documentation is hosted on https://documentation.ubuntu.com/, | ||
| # uncomment and set to the RTD slug. | ||
| # slug = "" |
There was a problem hiding this comment.
| # TODO: If your documentation is hosted on https://documentation.ubuntu.com/, | |
| # uncomment and set to the RTD slug. | |
| # slug = "" |
| # Copyright string; shown at the bottom of the page | ||
| copyright = "2023-%s, %s" % (datetime.date.today().year, author) | ||
| # The year in the copyright statement | ||
| copyright = f"2023-{datetime.date.today().year}" |
There was a problem hiding this comment.
Did Debcraft start that far back?
| # Add redirects to the 'redirects.txt' file | ||
| # https://sphinxext-rediraffe.readthedocs.io/en/latest/ | ||
|
|
||
| # To set up redirects in the Read the Docs project dashboard: | ||
| # https://docs.readthedocs.io/en/stable/guides/redirects.html | ||
|
|
There was a problem hiding this comment.
| # Add redirects to the 'redirects.txt' file | |
| # https://sphinxext-rediraffe.readthedocs.io/en/latest/ | |
| # To set up redirects in the Read the Docs project dashboard: | |
| # https://docs.readthedocs.io/en/stable/guides/redirects.html |
| 'js/bundle.js', | ||
| ] | ||
| # Adds custom JavaScript files, located remotely or in 'html_static_path'. | ||
| # TODO: Uncomment to enable Google Analytics on public projects. |
There was a problem hiding this comment.
| # TODO: Uncomment to enable Google Analytics on public projects. |
| 'css/cookie-banner.css' | ||
| ] | ||
| # Adds custom CSS files, located remotely or in 'html_static_path'. | ||
| # TODO: Uncomment to enable Google Analytics on public projects. |
There was a problem hiding this comment.
| # TODO: Uncomment to enable Google Analytics on public projects. |
Merge starbase/main into this branch and sync Starbase-managed updates.
Overview of Starbase changes pulled in
Conflict resolution applied