test: failing reproducer - no error for high UID (>65535) - #949
Draft
lengau wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproducer for #259
Enterprise systems using NIS, SSSD, or Active Directory commonly assign UIDs above 65535. When
map_user_uid=Truewith such a UID, LXD rejects it with:This message is cryptic. craft-providers should detect this condition and raise a clear
ProviderErrorbefore calling LXD.Failing test
test_set_id_map_raises_for_high_uid— shows that_set_id_map()currently callslxc.config_set(raw.idmap=...)for UIDs > 65535 rather than raising a descriptive error first.Fix
Add a check in
_set_id_map()before thelxc.config_setcall: ifuid > 65535, raise aProviderErrorwith a link to documentation.Closes #259