Skip to content

docs: declare slug in config - #1158

Merged
lengau merged 4 commits into
mainfrom
work/add-docs-slug
Aug 11, 2026
Merged

docs: declare slug in config#1158
lengau merged 4 commits into
mainfrom
work/add-docs-slug

Conversation

@jahn-junior

@jahn-junior jahn-junior commented Aug 11, 2026

Copy link
Copy Markdown
Contributor
  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint && make test?
  • Have you added an entry to the changelog (docs/reference/changelog.rst)?

Canonical Sphinx uses this to configure the sphinx-notfound-page extension.

Live 404 page: https://documentation.ubuntu.com/craft-application/oops

PR build 404 page: https://canonical-ubuntu-documentation-library--1158.com.readthedocs.build/craft-application/1158/oops

Signed-off-by: JJ Coldiron <jj.coldiron@canonical.com>
@jahn-junior
jahn-junior requested a review from lengau as a code owner August 11, 2026 15:45
Copilot AI lite review requested due to automatic review settings August 11, 2026 15:45
@jahn-junior
jahn-junior requested a review from a team as a code owner August 11, 2026 15:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Sphinx documentation configuration to explicitly declare the project slug, which Canonical Sphinx uses to configure the sphinx-notfound-page extension so 404 (“oops”) pages render consistently with Canonical’s standard.

Changes:

  • Define slug = "craft-application" in docs/conf.py to support Canonical Sphinx’s notfound-page configuration.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Updated the project slug comment for clarity.

Signed-off-by: JJ Coldiron <jj.coldiron@canonical.com>
Signed-off-by: JJ Coldiron <jj.coldiron@canonical.com>
Signed-off-by: JJ Coldiron <jj.coldiron@canonical.com>
@jahn-junior
jahn-junior requested a review from a team August 11, 2026 17:04
@lengau
lengau merged commit 9fcde8c into main Aug 11, 2026
28 checks passed
@lengau
lengau deleted the work/add-docs-slug branch August 11, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants