fix(lint): ignore PLR0917 in tests alongside PLR0913 - #1154
Merged
Conversation
make lint-ruff was failing with PLR0917 (too many positional arguments) errors across several test files that use many fixtures and parametrize decorators. Extend the existing test per-file-ignore for PLR0913 to also cover PLR0917, for the same reasoning. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Ruff lint configuration so test files ignore PLR0917 (“too many positional arguments”), aligning with the existing rationale for ignoring PLR0913 in tests where fixtures/parametrization commonly require many arguments.
Changes:
- Extend Ruff
per-file-ignoresfortests/**.pyto includePLR0917alongsidePLR0913.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lengau
marked this pull request as ready for review
August 10, 2026 21:37
mr-cal
approved these changes
Aug 11, 2026
cmatsuoka
approved these changes
Aug 11, 2026
lengau
added a commit
that referenced
this pull request
Aug 11, 2026
make lint-ruff was failing with PLR0917 (too many positional arguments) errors across several test files that use many fixtures and parametrize decorators. Extend the existing test per-file-ignore for PLR0913 to also cover PLR0917, for the same reasoning. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`make lint-ruff` was failing with 9 `PLR0917` (too many positional arguments) errors across several test files that use many fixtures and `@pytest.mark.parametrize` decorators.
This extends the existing test per-file-ignore for `PLR0913` to also cover `PLR0917`, for the same reasoning: test functions often need many positional arguments for fixtures/parametrization.
Testing
`make lint-ruff` now passes cleanly.