Open
chore: compute artifact digests by reading files in chunks#1134
Conversation
Copilot
AI
changed the title
[WIP] Read file by chunks for artifact digests
Compute artifact digests by reading files in chunks
Jul 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates artifact digest computation to avoid loading entire files into memory, improving behavior for large artifacts.
Changes:
- Reworked
Hashes.from_path()to stream file contents in 64KB chunks instead ofpath.read_bytes() - Updated digest computation to reuse
hashlibobjects via incrementalupdate()calls
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hashes.from_pathwas loading entire artifact files into memory viapath.read_bytes()before computing SHA1/SHA256 digests — a problem for large artifacts.Changes
craft_application/models/manifest.py: Replacedpath.read_bytes()with incremental 64KB chunk reads, feeding each chunk to both hash objects simultaneously.This matches the existing chunked-read pattern already used in
remote/utils.py. Once Python 3.10 support is dropped, this can be replaced withhashlib.file_digest().