Create the initial charm - #2
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has checked 63 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 20 | 3 | 40 | 0 |
Click to see the invalid file list
- lib/charms/operator_libs_linux/v0/apt.py
- lib/charms/operator_libs_linux/v1/systemd.py
- src/prometheus_alert_rules/chrony.rule
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
erinecon
left a comment
erinecon
left a comment
There was a problem hiding this comment.
Thanks for the initial documentation set!
| title Component diagram for Chrony client charm | ||
|
|
||
| System_Boundary(vm, "VM machine") { | ||
| Container(principal, "principal charm") |
There was a problem hiding this comment.
For my understanding, is the "principal charm" a Chrony charm?
There was a problem hiding this comment.
The principal charm can be any machine charm.
The chrony-client charm attaches to any machine charm and configures the NTP client on that machine. And target machine charm is called the principal charm in juju terms
erinecon
left a comment
erinecon
left a comment
There was a problem hiding this comment.
Thanks for implementing my suggestions! Two more nitpicks to consider
erinecon
left a comment
erinecon
left a comment
There was a problem hiding this comment.
The documentation is looking great! Here's another round of comments from me (mostly updating relate to integrate).
Co-authored-by: Erin Conley <erin.conley@canonical.com>
erinecon
left a comment
erinecon
left a comment
There was a problem hiding this comment.
A few more nitpicks I noticed, but it's a 👍 on the documentation side of things. Thanks!
Co-authored-by: Erin Conley <erin.conley@canonical.com>
|
@weiiwang01 Can a screenshot of the Grafana dashboard be included here? |
Yes, added in the description, thanks! |
|
[Ninja] @weiiwang01 Hello Weii! Would this item still be relevant? |
Yes, it is waiting to be merged. |
6 participants
Overview
Create the initial version of the
chrony-clientsubordinate charm, which installs and configures Chrony on the target machine.This pull request includes:
chrony-clientcharmchrony-clientcharmGrafana Dashboard:
Rationale
Juju Events Changes
Module Changes
Library Changes
Checklist
urgent,trivial,senior-review-required,documentation)docs/changelog.mdis updated with user-relevant changes.