Replace pkg_resources with importlib.metadata - #269
Open
raineszm wants to merge 1 commit into
Open
Conversation
pkg_resources was removed in setuptools 82 forcing any dependency to pin setuptools <82 if using pkg_resources. This change replaces the one function used from pkg_resources with the equivalent from importlib.metadata so that reactive charms don't have to pin setuptools. Signed-off-by: Zachary Raines <zachary.raines@canonical.com>
Author
|
It looks like attempting to test on 3.7 is breaking the CI test suite. Is it acceptable to change the tests to 3.8+ since <3.8 hasn't been supported since bionic? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg_resources was removed in setuptools 82 forcing any dependency to pin
setuptools <82 if using pkg_resources. This change replaces the one
function used from pkg_resources with the equivalent from
importlib.metadata so that reactive charms don't have to pin setuptools.
The implementation just writes a thin shim for
iter_entry_points, taking into account version differences for importlib.metadata.