add global pragma styles - #2404
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces Pragma-related global styling by adding Canonical’s @canonical/styles into the main SCSS pipeline so its tokens/base styles load before Vanilla Framework.
Changes:
- Import
@canonical/stylesat the top ofstatic/sass/styles.scss(before Vanilla). - Add new npm dependencies:
@canonical/stylesand@canonical/react-ds-global. - Update
yarn.lockto reflect the new dependency graph.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
static/sass/styles.scss |
Imports @canonical/styles before Vanilla to apply Pragma tokens/base styles globally. |
package.json |
Adds @canonical/styles (used by SCSS) and @canonical/react-ds-global (currently appears unused and introduces an additional React version). |
yarn.lock |
Locks the new dependencies and their transitive packages. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@steverydz could you take another quick look please? 🙏 |
steverydz
left a comment
There was a problem hiding this comment.
LGTM 👍
Just a note though that there will be some work needed to make sure the Pragma icons are available (see: https://github.com/canonical/snapcraft.io/pull/5805/changes)
yep, that's fine. discussed with Bartek and we said we would wait until the snapcraft PR is merged and see if we discover any other teething issues. will address this in a later PR :) |
Done
How to QA
Testing
Issue / Card
Fixes WD-38210
UX Approval
Stack created with GitHub Stacks CLI • Give Feedback 💬