test: speed up spread test runtime by removing redundant package setup - #2774
Draft
lengau wants to merge 4 commits into
Draft
test: speed up spread test runtime by removing redundant package setup#2774lengau wants to merge 4 commits into
lengau wants to merge 4 commits into
Conversation
Avoid redundant apt index refreshes in top-level spread prepare by relying on tests.pkgs install and installing snapd+unzip in one invocation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Drop per-task tests.pkgs unzip installs now that the suite-level spread prepare installs unzip once for all tasks. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
lengau
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces Spread test runtime by removing redundant package installation steps and relying on a single global package setup in spread.yaml.
Changes:
- Removed a manual
apt-get updatefrom the top-level Spreadpreparestep. - Consolidated global package installation into a single
tests.pkgs install snapd unzipcall. - Dropped per-task
tests.pkgs install unzipcalls whereunzipis now guaranteed globally.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
spread.yaml |
Removes the explicit apt-get update and installs snapd + unzip together via tests.pkgs. |
tests/spread/smoketests/remote-build/task.yaml |
Removes per-task unzip install; relies on global availability. |
tests/spread/smoketests/pinned-dependencies/task.yaml |
Removes per-task unzip install; relies on global availability. |
tests/spread/smoketests/parallel-build/task.yaml |
Removes per-task unzip install; relies on global availability. |
tests/spread/smoketests/metafiles-unified-charmcraft-yaml/task.yaml |
Removes per-task unzip install; relies on global availability. |
tests/spread/smoketests/metafiles-multiple-yaml/task.yaml |
Removes per-task unzip install; relies on global availability. |
tests/spread/smoketests/metafiles-bad-yaml-unenforced/task.yaml |
Removes per-task unzip install; relies on global availability. |
tests/spread/smoketests/different-dependencies/task.yaml |
Removes per-task unzip install; relies on global availability. |
tests/spread/hooks/remove/task.yaml |
Removes per-task unzip install; relies on global availability. |
tests/spread/hooks/configure/task.yaml |
Removes per-task unzip install; relies on global availability. |
tests/spread/dependencies/strict-dependencies/task.yaml |
Removes per-task unzip install; relies on global availability. |
lengau
commented
Jul 11, 2026
Signed-off-by: Alex Lowe <alex.lowe@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Impact
This removes repeated package-index refreshes in spread runs, reducing runtime while preserving test coverage and assertions.