chore: remove ops dependency in framework templates - #2733
Open
Thanhphan1147 wants to merge 15 commits into
Open
chore: remove ops dependency in framework templates#2733Thanhphan1147 wants to merge 15 commits into
Thanhphan1147 wants to merge 15 commits into
Conversation
…tensions - Add conditional dpcharmlibs-interfaces injection via charm-python-packages when valkey_client interface is declared in requires - Add commented valkey relation to all framework init templates - Add Valkey integration to integrations.rst documentation - Add Valkey environment variables to environment_variables.rst - Add regression test for valkey python package injection Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ll add it as a dependency for paas-charm
…rt_valkey_client_interface
…rt_valkey_client_interface
…rt_valkey_client_interface
…lient_interface' of github.com:Thanhphan1147/charmcraft into update_init_template_and_extensions_to_support_valkey_client_interface
Bumps ops dependency from ~= 2.17 to ~= 3.7 in all framework requirements.txt.j2 templates to ensure compatibility with dpcharmlibs-interfaces>=1.0.0 which requires ops>=3. This enables compatibility with paas-charm 1.11.3+.
Thanhphan1147
marked this pull request as ready for review
June 17, 2026 18:18
Contributor
Author
|
Hi @lengau, This PR is ready for review. I found this issue during testing which preventing charms to install paas_charm v1.11.3 which contains the support for valkey |
Thanhphan1147
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the explicit ops dependency from the framework requirements.txt.j2 templates, relying instead on paas-charm to bring in ops as a dependency.
Changes:
- Dropped
opsfrom Django/Flask/FastAPI/Go/Spring Boot/ExpressJS frameworkrequirements.txt.j2templates. - Kept
paas-charm>=1.0,<2as the sole requirement in those templates.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| charmcraft/templates/init-spring-boot-framework/requirements.txt.j2 | Removes explicit ops requirement; keeps paas-charm only. |
| charmcraft/templates/init-go-framework/requirements.txt.j2 | Removes explicit ops requirement; keeps paas-charm only. |
| charmcraft/templates/init-flask-framework/requirements.txt.j2 | Removes explicit ops requirement; keeps paas-charm only. |
| charmcraft/templates/init-fastapi-framework/requirements.txt.j2 | Removes explicit ops requirement; keeps paas-charm only. |
| charmcraft/templates/init-expressjs-framework/requirements.txt.j2 | Removes explicit ops requirement; keeps paas-charm only. |
| charmcraft/templates/init-django-framework/requirements.txt.j2 | Removes explicit ops requirement; keeps paas-charm only. |
lengau
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opsdependency from all frameworkrequirements.txt.j2templates sincepaas-charmalready listsopsas a dependency