ci: fix attest job for multi-arch rock, drop SBOM/scan - #85
Open
tonyandrewmeyer wants to merge 7 commits into
Open
ci: fix attest job for multi-arch rock, drop SBOM/scan#85tonyandrewmeyer wants to merge 7 commits into
tonyandrewmeyer wants to merge 7 commits into
Conversation
tonyandrewmeyer
marked this pull request as ready for review
July 22, 2026 08:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
attest-and-scanjob was failing because syft can't parse a multi-arch OCI archive (unexpected media type application/vnd.oci.image.index.v1+json). I realised (belatedly, sorry) I could test this in my fork (passing example) so have reworked it there.One significant change: it turns out that even though our security team recommend grype, it doesn't understand bare rocks. I was able to work around that for getting the right base, but there are still many false positives because it doesn't understand the Python packages (plus some actual Go issues that should be fixed with some dependency bumps). It seems like the tool is just not usable with a chiselled rock, so I've dropped the scanning part entirely. It isn't strictly needed here since this is a demo image rather than a real product, so we'll just rely on whatever the rock team does. Without the scan, the syft SBOM doesn't provide much value.
I've kept the build provenance attestsrion, though.
Changes:
archand download the per-arch.rockartifact via glob +merge-multiple: true, resolving the filename dynamically. This fixes the main blocking issue.attest-and-scan→attest; updateupload-ghcrneeds accordingly.I've also dropped the
secrets: source-github-tokenblock. The repo is public, so as far as I can tell the reusable build workflow doesn't needREPO_CLONER_TOKENfor cloning. I had to do this to have it work in my fork, but it seems like it's not needed incanonicaleither. Let me know if I missed something here and I can restore it.