Skip to content

ci: use correct full-version tags for all pinned actions - #84

Merged
dwilding merged 3 commits into
canonical:masterfrom
dwilding:upload-sarif-action
Jul 16, 2026
Merged

ci: use correct full-version tags for all pinned actions#84
dwilding merged 3 commits into
canonical:masterfrom
dwilding:upload-sarif-action

Conversation

@dwilding

@dwilding dwilding commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

This PR fixes the comment tag for codeql-action/upload-sarif, to match the commit hash we're pinned at.

I'm also updating the commit hash for craft-actions/rockcraft-pack and adding a comment tag. The repo recently started tagging commits.

I'm also making sure that all other actions have comments with full-version tags.

Fixes https://github.com/canonical/api_demo_server/security/code-scanning/47

@dwilding
dwilding requested a review from tonyandrewmeyer July 16, 2026 06:56
@dwilding dwilding changed the title ci: use correct tag for upload-sarif and pin rockcraft-pack at a tag ci: use correct full-version tags for all pinned actions Jul 16, 2026
steps:
- name: Upload Rock to GHCR
uses: canonical/oci-factory/.github/actions/upload-rock@de55cd493720fc91cf5b629a34a10b3be7b0434a # memcached_1.6-26.04_edge
uses: canonical/oci-factory/.github/actions/upload-rock@de55cd493720fc91cf5b629a34a10b3be7b0434a # memcached_1.6-26.04_35

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_edge is a moving target and doesn't match this commit hash now.

@dwilding

Copy link
Copy Markdown
Collaborator Author

Ready for review now @tonyandrewmeyer - thanks

@tonyandrewmeyer tonyandrewmeyer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked all the actions and can't find any missed, and these all match. Thanks! And sorry for getting this wrong when I added the hash pins.

@dwilding
dwilding merged commit 4806f35 into canonical:master Jul 16, 2026
10 checks passed
@dwilding
dwilding deleted the upload-sarif-action branch July 16, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants