Proficiencies - #176
Open
PJBrs wants to merge 6 commits into
Open
Conversation
Various proficiency options exist that actually require the player to choose something, such as: three musical instruments of your choice; or one set of artisan's tools. These should not be listed as such on the character sheet. Put each of these choices in brackets, like done for a couple of such choices already, and for language options. This way, we can filter these options out in character.py.
Some proficiencies represent options that the player has to choose from. Distinguish these from other proficiencies.
Various races, backgrounds and classes contain choices for proficiencies such as "one skill from ranger list" or "three musical instruments." Add these to the player's character file at character creation, as a reminder that they change these later, just as done already with language choices. This is best tested by creating a multiclass Bard (5), Ranger (4), Rogue (3) Hobgoblin character, which will have optional skills, instruments, and weapons.
The epub output format didn't list any proficiencies anymore since various recent changes I made. This patch fixes that problem. I worked around an issue in the epub gm files output, where it is possible to have a monster as a character. In that case, proficiencies_by_type is not initialised, resulting in the following error: jinja2.exceptions.UndefinedError: 'dungeonsheets.monsters.monsters_v.Veteran object' has no attribute 'proficiencies_by_type' It does make me think whether is would be possible to rename the proficiencies_by_type method to proficiencies_text, which will be initialised by definition, and then use rst and a jinja filter for formatting instead...
Contributor
Author
|
@canismarko I hope this message finds you well. It would be really nice to get back to this PR again! Also see my comments in Discord. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has five patches that affect how user-chosen proficiencies are listed and treated. The intended result is the same as with how languages are treated, as in - if your background affords you an additional language, it is listed as [choose one] in your character file. Compare: "One type of artisan's tools", "Three musical instruments of your choice"
As end result, a user would, for instance, create a bard. This would add [choose three musical instruments] to the character file. When the user has not removed this choice and substituted it with three instruments, makesheets will warn that the user still needs to choose.