Repository navigation
Publish Windows CLI packages alongside NuGet on main - #70
Merged
Merged
Conversation
cangelosilima
marked this pull request as ready for review
October 4, 2026 05:00
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Quality resultsQuality gate: success
CLI line, branch, method, and full method coverage must each reach 100%. A missing report is shown as unavailable. See the linked run for test failures, detailed CLI/Site coverage summaries and HTML reports, and scanner results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Chocolatey and WinGet distribution for the Windows x64
syncsqlCLI. The CLI NuGet workflow calls Windows packaging alongside its publish job, sharing the version, release tag and tested commit. Only protected-main push events publish.Validation: 14 packaging/release tests passed; actionlint passed for all three changed workflows; the clean Windows build and CLI smoke test passed. The shared installation assertion accepted the built binary and rejected an incorrect version. Public-source installation jobs require publication and have not run locally.
Earlier validation: solution build and CLI tests/coverage passed (100% coverage). Site formatting, lint, type checks and coverage passed; one existing packaging test exceeded its 5-second timeout. The pre-push hook did not reach mutation checks; pushes used the documented hook exception. No site code changes are included.
Local Node 25 tests need
NODE_OPTIONS=--no-experimental-webstorage. The hook's checkout-filter test needs an explicitGIT_WORK_TREEwhen tests run fromsite/.