Fill the docker section - #42
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
campoy
left a comment
campoy
left a comment
There was a problem hiding this comment.
Hey, thanks so much for this! I sent a couple of comments, I'll send more once you've done these edits.
| - Local development | ||
|
|
||
| ### Continuous integration | ||
| When using a CI server like Jenkins, it can become cumbersome to have to install all the go versions required by your different projects. And even more if you use your CI server to build projects in other languages, each with its own version (java8, java7, node, ruby, python, ...). For this use case, it can be easier to build the projects in docker containers. An example script could be : |
There was a problem hiding this comment.
please break this into lines for easier review
|
|
||
| ### Continuous integration | ||
| When using a CI server like Jenkins, it can become cumbersome to have to install all the go versions required by your different projects. And even more if you use your CI server to build projects in other languages, each with its own version (java8, java7, node, ruby, python, ...). For this use case, it can be easier to build the projects in docker containers. An example script could be : | ||
| ``` |
| ### Continuous integration | ||
| When using a CI server like Jenkins, it can become cumbersome to have to install all the go versions required by your different projects. And even more if you use your CI server to build projects in other languages, each with its own version (java8, java7, node, ruby, python, ...). For this use case, it can be easier to build the projects in docker containers. An example script could be : | ||
| ``` | ||
| docker run --rm -v $PWD:/go/src/github.com/repo/project -w /go/src/github.com/repo/project golang:1.8.1 go build -o dist/binary |
There was a problem hiding this comment.
because copy/pasting from another script 😇 I'll remove the option
| This will run the `go build` command with go version 1.8.1, sharing your current directory with the container. Obviously, you can run `go fmt/vet/test/...` commands the same way | ||
|
|
||
| ### Cross building binary | ||
| Usually, cross building a binary requires to install go from sources. Using the golang image, you can install the binary distribution on your computer for day-to-day use and rely on the docker image to build binaries for different targets. |
There was a problem hiding this comment.
This is wrong, you can cross compile by installing Go with an installer to install from source
There was a problem hiding this comment.
OK, I don't know how to do that TBH. Maybe my use case of using the golang image to generate binary is not a good example and you want to drop it ?
| ``` | ||
| This will run the `go build` command with go version 1.8.1, sharing your current directory with the container. Obviously, you can run `go fmt/vet/test/...` commands the same way | ||
|
|
||
| ### Cross building binary |
There was a problem hiding this comment.
I expect this section to talk about how you can do
$ GOOS=linux go build
$ docker build .Where Dockerfile adds the linux binary
There was a problem hiding this comment.
hmmm... sorry don't understand what you mean here. The use case I have in mind in this section is only to use docker run to generate a binary, nothing more. Building an image by adding the binary in the Dockerfile is shown as an example in the sections below.
add bash syntax highlighting to command scripts
|
I've integrated part or your remarks. I don't fully understand what you expect from the Cross building binary section, I let you read my comments. |
|
Hey, I just came back from holidays and I'll be reviewing this in a couple days. Thanks so much! |
3 participants
Proposal for your issue #5