Skip to content

Ignore SIGPIPE when serving #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
funwithcthulhu wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Ignore SIGPIPE when serving #429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/http/http.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,6 +687,10 @@ let on_termination_signal () =
ignore (Lwt_unix.on_signal Sys.sigint (fun _ -> Lwt.wakeup_later int_resolve ()));
Lwt.pick [term_promise; int_promise]

let ignore_sigpipe () =
if Sys.unix then
Sys.(set_signal sigpipe Signal_ignore)

let network ~port ~socket_path =
match socket_path with
| None -> `Inet port
Expand All @@ -704,6 +708,8 @@ let serve
?(builtins = true)
user's_dream_handler =

ignore_sigpipe ();

serve_with_maybe_https
"serve"
~interface
Expand Down Expand Up @@ -734,9 +740,7 @@ let run
?adjust_terminal
user's_dream_handler =

let () = if Sys.unix then
Sys.(set_signal sigpipe Signal_ignore)
in
ignore_sigpipe ();

let log = Log.convenience_log in

Expand Down
Loading