Skip to content

Fix GraphQL example schema construction #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
funwithcthulhu wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix GraphQL example schema construction #428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions example/i-graphql/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ let hardcoded_users = [
{id = 2; name = "bob"};
]

let user =
let user () =
Graphql_lwt.Schema.(obj "user"
~fields:[
field "id"
Expand All @@ -30,7 +30,8 @@ let user =
~resolve:(fun _info user -> user.name);
])

let schema =
let schema () =
let user = user () in
Graphql_lwt.Schema.(schema [
field "users"
~typ:(non_null (list (non_null user)))
Expand All @@ -52,7 +53,7 @@ let () =
@@ Dream.logger
@@ Dream.origin_referrer_check
@@ Dream.router [
Dream.any "/graphql" (Dream.graphql Lwt.return schema);
Dream.any "/graphql" (Dream.graphql Lwt.return (schema ()));
Dream.get "/" (Dream.graphiql ~default_query "/graphql");
]
```
Expand Down
7 changes: 4 additions & 3 deletions example/i-graphql/graphql.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ let hardcoded_users = [
{id = 2; name = "bob"};
]

let user =
let user () =
Graphql_lwt.Schema.(obj "user"
~fields:[
field "id"
Expand All @@ -18,7 +18,8 @@ let user =
~resolve:(fun _info user -> user.name);
])

let schema =
let schema () =
let user = user () in
Graphql_lwt.Schema.(schema [
field "users"
~typ:(non_null (list (non_null user)))
Expand All @@ -40,6 +41,6 @@ let () =
@@ Dream.logger
@@ Dream.origin_referrer_check
@@ Dream.router [
Dream.any "/graphql" (Dream.graphql Lwt.return schema);
Dream.any "/graphql" (Dream.graphql Lwt.return (schema ()));
Dream.get "/" (Dream.graphiql ~default_query "/graphql");
]
9 changes: 6 additions & 3 deletions example/r-graphql/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ let hardcoded_users = [
{id: 2, name: "bob"},
];

let user =
let user = () =>
Graphql_lwt.Schema.(
obj("user", ~fields=
[
Expand All @@ -35,7 +35,9 @@ let user =
)
);

let schema =
let schema = () => {
let user = user();

Graphql_lwt.Schema.(
schema([
field(
Expand All @@ -54,6 +56,7 @@ let schema =
}),
])
);
};

let default_query =
"{\\n users {\\n name\\n id\\n }\\n}\\n";
Expand All @@ -63,7 +66,7 @@ let () =
@@ Dream.logger
@@ Dream.origin_referrer_check
@@ Dream.router([
Dream.any("/graphql", Dream.graphql(Lwt.return, schema)),
Dream.any("/graphql", Dream.graphql(Lwt.return, schema())),
Dream.get("/", Dream.graphiql(~default_query, "/graphql")),
]);
```
Expand Down
9 changes: 6 additions & 3 deletions example/r-graphql/graphql.re
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ let hardcoded_users = [
{id: 2, name: "bob"},
];

let user =
let user = () =>
Graphql_lwt.Schema.(
obj("user", ~fields=
[
Expand All @@ -23,7 +23,9 @@ let user =
)
);

let schema =
let schema = () => {
let user = user();

Graphql_lwt.Schema.(
schema([
field(
Expand All @@ -42,6 +44,7 @@ let schema =
}),
])
);
};

let default_query =
"{\\n users {\\n name\\n id\\n }\\n}\\n";
Expand All @@ -51,6 +54,6 @@ let () =
@@ Dream.logger
@@ Dream.origin_referrer_check
@@ Dream.router([
Dream.any("/graphql", Dream.graphql(Lwt.return, schema)),
Dream.any("/graphql", Dream.graphql(Lwt.return, schema())),
Dream.get("/", Dream.graphiql(~default_query, "/graphql")),
]);
Loading